Skip to content

Commit 4cf9c02

Browse files
committed
fix(leptos): some sugested fixes
1 parent 198b437 commit 4cf9c02

File tree

2 files changed

+7
-5
lines changed

2 files changed

+7
-5
lines changed

crates/leptos/src/avatar.rs

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -4,17 +4,17 @@ use leptos::prelude::*;
44
#[component]
55
pub fn Avatar(
66
#[prop(into)] url: String,
7-
#[prop(into, optional)] alt: Option<String>,
8-
#[prop(into, optional, default = Some(32))] size: Option<i32>,
7+
#[prop(into, optional)] alt: String,
8+
#[prop(into, optional, default = 32)] size: i32,
99
#[prop(into, optional)] class: String,
1010
) -> impl IntoView {
1111
let class = crate::tw!(concat!(BASE_CLASS, "-avatar"), class);
1212

1313
view! {
1414
<div
1515
class={class}
16-
style:width={size.map(|size| format!("{size}px"))}
17-
style:height={size.map(|size| format!("{size}px"))}
16+
style:width={format!("{size}px")}
17+
style:height={format!("{size}px")}
1818
>
1919
<img class="rustlanges-avatar__img" src={url} alt={alt} />
2020
</div>

crates/leptos/src/flap.rs

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,8 @@ use leptos::prelude::*;
33
use leptos::{IntoView, component, view};
44
use tailwind_fuse::{AsTailwindClass, TwVariant};
55

6+
use crate::icons::StarBold;
7+
68
#[derive(TwVariant, PartialEq)]
79
pub enum Variant {
810
#[tw(default, class = "text-primary-400")]
@@ -41,7 +43,7 @@ pub fn Flap(
4143
(variant == Variant::Highlight).then_some(concat!(BASE_CLASS, "-flap__view--icon")),
4244
)}
4345
>
44-
{(variant == Variant::Highlight).then_some(view! { <> </> })}
46+
{(variant == Variant::Highlight).then_some(view! { <StarBold /> })}
4547
<span class={concat!("text-paragraph-2 ", BASE_CLASS, "-flap__view-text")}>
4648
{label.clone()}
4749
</span>

0 commit comments

Comments
 (0)