Skip to content

fix(ui5-toolbar-button): add css for ui5-toolbar-button for left alignment (#11913) #11914

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 20, 2025
Merged

fix(ui5-toolbar-button): add css for ui5-toolbar-button for left alignment (#11913) #11914

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
3ca56d5
fix(ui5-toolbar-button): add css for ui5-toolbar-button for left alig…
Jianrong-Yu Jul 14, 2025
3e6bc05
Merge branch 'main' into fix-toolbar-button-alignment
Jianrong-Yu Jul 16, 2025
f89a220
fix(ui5-toolbar-button): add padding for icon-only button in popover
Jianrong-Yu Jul 18, 2025
3a279e4
Merge branch 'main' into fix-toolbar-button-alignment
Jianrong-Yu Jul 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions packages/main/src/ToolbarButton.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,8 @@ import type ButtonDesign from "./types/ButtonDesign.js";
import ToolbarItem from "./ToolbarItem.js";
import ToolbarButtonTemplate from "./ToolbarButtonTemplate.js";

import ToolbarButtonCss from "./generated/themes/ToolbarButton.css.js";

type ToolbarButtonAccessibilityAttributes = ButtonAccessibilityAttributes;

/**
Expand All @@ -29,6 +31,7 @@ type ToolbarButtonAccessibilityAttributes = ButtonAccessibilityAttributes;
tag: "ui5-toolbar-button",
template: ToolbarButtonTemplate,
renderer: jsxRenderer,
styles: [ToolbarButtonCss],
})

/**
Expand Down
4 changes: 4 additions & 0 deletions packages/main/src/themes/ToolbarButton.css
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@

.ui5-tb-popover-item.ui5-tb-button::part(button) {
justify-content: start;
}
3 changes: 0 additions & 3 deletions packages/main/src/themes/ToolbarButtonPopover.css
View file
Open in desktop

This file was deleted.

2 changes: 2 additions & 0 deletions packages/main/test/pages/Toolbar.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -152,6 +152,8 @@
<ui5-toolbar-separator></ui5-toolbar-separator>
<ui5-toolbar-button icon="employee" text="Call me later" stable-dom-ref="tb-button-employee-d"
overflow-priority="AlwaysOverflow"></ui5-toolbar-button>
<ui5-toolbar-button icon="decline" text="Longer for alignment check"
stable-dom-ref="tb-button-employee-d" overflow-priority="AlwaysOverflow"></ui5-toolbar-button>
</ui5-toolbar>
</section>

Expand Down
Loading