fix(ui5-date-picker): adjust value state message text #12245
+120
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR fixes value state message text handling in DatePicker components by addressing the nested slot structure issue when forwarding value state messages from DatePicker to its internal DateTimeInput component.
- Overrides
ariaValueStateHiddenTextgetter in DateTimeInput to properly extract text from nested slot structures - Adds comprehensive Cypress tests to verify the accessibility text extraction works correctly
- Includes a test page example to demonstrate the fix
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| packages/main/src/DateTimeInput.ts | Adds overridden ariaValueStateHiddenText getter to handle nested slot structure and extract proper text content for accessibility |
| packages/main/cypress/specs/DatePicker.cy.tsx | Adds comprehensive test coverage for the nested slot accessibility text extraction functionality |
| packages/main/test/pages/DatePicker.html | Adds simple test case with value state message slot for manual testing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed: #11803