feature(design): add scrolling while dragging #244
Conversation
| () => ({ | ||
| isDesignMode: isDesignModeActive(), | ||
| isPreviewMode: isPreviewModeActive(), | ||
| isDesignMode: mode === 'design' || isDesignModeActive(), |
There was a problem hiding this comment.
This allows for us to set a mode programmatically when consumed. Useful if we want an alternative to the url parameter, for example, in storybook we can't control the url parameters. In Odyssey we won't provide a mode so this will default to the behavior it had before.
| ComponentPropertiesChanged: Domain.ComponentPropertiesChangedEvent; | ||
| MediaChangedEvent: Domain.MediaChangedEvent; | ||
| ClientWindowBoundsHoverOver: Domain.ClientWindowBoundsHoverOverEvent; | ||
| ClientWindowBoundsHoverOut: Domain.ClientWindowBoundsHoverOutEvent; |
There was a problem hiding this comment.
Did we find that we just don't need these?
| }): (query: { | ||
| x: number; | ||
| y: number; | ||
| filter?: (entry: NodeToTargetMapEntry) => boolean; |
There was a problem hiding this comment.
What does filter do? It's an optional parameter that users can pass into the function that gets returned by useComponentDiscovery? Where do we expect to use this?
| const node = nodeStack[i]; | ||
| const entry = nodeToTargetMap.get(node); | ||
|
|
||
| // We need a region id and direction for this to be a target. |
There was a problem hiding this comment.
Are we actually filtering on region id and direction here? Would they have to pass in a filter function that does that?
| const SCROLL_INTERVAL_IN_MS = 1000 / 60; // 60fps | ||
| // The multiplier applied to the scroll factor. | ||
| // The scroll factor is a value between 0 and 1 that determines how much to scroll. | ||
| // This value will be the maximum amount of pixels that will be scrolled in a singal frame. |
There was a problem hiding this comment.
| // This value will be the maximum amount of pixels that will be scrolled in a singal frame. | |
| // This value will be the maximum amount of pixels that will be scrolled in a single frame. |
| for (let i = 0; i < stack.length; i += 1) { | ||
| const entry = stack[i]; | ||
|
|
||
| // We need a region id and direction for this to be a target. |
There was a problem hiding this comment.
Should we just pass a filter function into discoverComponents instead of having this outer if check here?
| isDragging: true, | ||
| currentDropTarget: null, | ||
| pendingTargetCommit: false, | ||
| scrollDirection: computeScrollDirection(scrollFactorRef.current), |
There was a problem hiding this comment.
Would this just be 0 all the time?
| scrollDirection: computeScrollDirection(scrollFactorRef.current), | |
| scrollDirection: 0, |
2 participants
Uh oh!
There was an error while loading. Please reload this page.