From f1cb99ad796755f54044e9c3f991b10ecd2b04a0 Mon Sep 17 00:00:00 2001 From: ChrisRackauckas Date: Thu, 23 Oct 2025 10:11:06 -0400 Subject: [PATCH 1/2] Fix Julia 1.12 deprecation warning for Pipe constructor MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit This commit addresses issue #412 where Julia 1.12 triggers a warning during precompilation about the Pipe constructor being extended without explicit qualification. The warning occurred because `@deprecate Pipe Tube` was ambiguous - Julia couldn't determine if we were creating a new function or extending `Base.Pipe`. Fix: Added explicit `function Pipe end` declaration before the deprecation to clearly indicate we're creating a new generic function, not extending Base.Pipe. Fixes #412 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude --- src/Hydraulic/IsothermalCompressible/components.jl | 1 + 1 file changed, 1 insertion(+) diff --git a/src/Hydraulic/IsothermalCompressible/components.jl b/src/Hydraulic/IsothermalCompressible/components.jl index b91bcda2..a74a50fb 100644 --- a/src/Hydraulic/IsothermalCompressible/components.jl +++ b/src/Hydraulic/IsothermalCompressible/components.jl @@ -202,6 +202,7 @@ Constant length internal flow model discretized by `N` (`FixedVolume`: `N`, `Tub return System(eqs, t, vars, pars; name, systems = [ports; pipe_bases; volumes]) end +function Pipe end @deprecate Pipe Tube """ From f63ab237ffca75e24b435823173311ca556b7321 Mon Sep 17 00:00:00 2001 From: Christopher Rackauckas Date: Thu, 23 Oct 2025 10:27:59 -0400 Subject: [PATCH 2/2] Update src/Hydraulic/IsothermalCompressible/components.jl --- src/Hydraulic/IsothermalCompressible/components.jl | 2 -- 1 file changed, 2 deletions(-) diff --git a/src/Hydraulic/IsothermalCompressible/components.jl b/src/Hydraulic/IsothermalCompressible/components.jl index a74a50fb..305e9610 100644 --- a/src/Hydraulic/IsothermalCompressible/components.jl +++ b/src/Hydraulic/IsothermalCompressible/components.jl @@ -202,8 +202,6 @@ Constant length internal flow model discretized by `N` (`FixedVolume`: `N`, `Tub return System(eqs, t, vars, pars; name, systems = [ports; pipe_bases; volumes]) end -function Pipe end -@deprecate Pipe Tube """ FlowDivider(; n, name)