fix Non-Numeric-u0 (#737)

* fix Non-Numeric-u0

* typo

Author: oscardssmith

lib/NonlinearSolveBase/src/solve.jl

@@ -151,11 +151,8 @@ function solve_call(_prob, args...; merge_callbacks = true, kwargshandle = nothi
                 throw(NonConcreteEltypeError(RecursiveArrayTools.recursive_unitless_eltype(_prob.u0)))
             end
 
-            if !(eltype(_prob.u0) <: Number) && !(eltype(_prob.u0) <: Enum) &&
-               !(_prob.u0 isa AbstractVector{<:AbstractArray} && _prob isa BVProblem)
-                # Allow Enums for FunctionMaps, make into a trait in the future
-                # BVPs use Vector of Arrays for initial guesses
-                throw(NonNumberEltypeError(eltype(_prob.u0)))
+            if !(eltype(_prob.u0) <: Number) && !(eltype(_prob.u0) <: Enum)
+                throw(SciMLBase.NonNumberEltypeError(eltype(_prob.u0)))
             end
         end
 

test/core_tests.jl

@@ -444,3 +444,10 @@ end
     sol = solve(prob)
     @test SciMLBase.successful_retcode(sol)
 end
+
+@testitem "NonNumberEltype error" tags=[:core] begin
+    u0_broken = [rand(2), rand(2)]
+    f(u,p) = u
+    prob = NonlinearProblem(f, u0_broken)
+    @test_throws SciMLBase.NonNumberEltypeError solve(prob)
+end