diff --git a/benchmarks/bm_runner.py b/benchmarks/bm_runner.py index 10d0f7ced4..dc2e174f52 100755 --- a/benchmarks/bm_runner.py +++ b/benchmarks/bm_runner.py @@ -140,11 +140,21 @@ def _asv_compare( ) -> None: """Run through a list of commits comparing each one to the next.""" commits = tuple(commit[:8] for commit in commits) + + machine_script = [ + "from asv.machine import Machine", + "print(Machine.get_unique_machine_name())", + ] + machine_name = _subprocess_runner_capture( + ["python", "-c", ";".join(machine_script)] + ) + for i in range(len(commits) - 1): before = commits[i] after = commits[i + 1] asv_command = shlex.split( - f"compare {before} {after} --factor={COMPARE_FACTOR} --split" + f"compare {before} {after} " + f"--machine {machine_name} --factor={COMPARE_FACTOR} --split" ) comparison = _subprocess_runner_capture(asv_command, asv=True) diff --git a/docs/src/whatsnew/latest.rst b/docs/src/whatsnew/latest.rst index 9022446cb8..0b18177a41 100644 --- a/docs/src/whatsnew/latest.rst +++ b/docs/src/whatsnew/latest.rst @@ -72,7 +72,10 @@ This document explains the changes made to Iris for this release 💼 Internal =========== -#. N/A +#. `@trexfeathers`_ fixed benchmark result comparison to inspect the results + for the current machine only. This is useful for setups where a single + home-space is shared between multiple machines, as with some virtual desktop + arrangements. (:pull:`6550`) .. comment