Skip to content

Commit f4fe441

Browse files
authored
Merge pull request #66 from bimdata/fix-setup_joins-unpacking
fix setup_joins unpacking
2 parents 290c6d0 + ae4a67c commit f4fe441

File tree

1 file changed

+8
-6
lines changed

1 file changed

+8
-6
lines changed

psqlextra/query.py

Lines changed: 8 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -61,11 +61,11 @@ def add_join_conditions(self, conditions: Dict[str, Any]) -> None:
6161

6262
for name, value in conditions.items():
6363
parts = name.split(LOOKUP_SEP)
64-
_, targets, _, joins, path = self.setup_joins(parts, opts, alias, allow_many=True)
65-
self.trim_joins(targets, joins, path)
64+
join_info = self.setup_joins(parts, opts, alias, allow_many=True)
65+
self.trim_joins(join_info.targets, join_info.joins, join_info.path)
6666

67-
target_table = joins[-1]
68-
field = targets[-1]
67+
target_table = join_info.joins[-1]
68+
field = join_info.targets[-1]
6969
join = self.alias_map.get(target_table)
7070

7171
if not join:
@@ -115,8 +115,10 @@ def add_fields(self, field_names: List[str], allow_m2m: bool=True) -> bool:
115115
)
116116
continue
117117

118-
_, targets, _, joins, path = self.setup_joins(parts, opts, alias, allow_many=allow_m2m)
119-
targets, final_alias, joins = self.trim_joins(targets, joins, path)
118+
join_info = self.setup_joins(parts, opts, alias, allow_many=allow_m2m)
119+
targets, final_alias, joins = self.trim_joins(
120+
join_info.targets, join_info.joins, join_info.path
121+
)
120122

121123
for target in targets:
122124
cols.append(target.get_col(final_alias))

0 commit comments

Comments
 (0)