Add support for :through associations
#630
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshuay03
force-pushed
the
through-association-support
branch
from
de3a801 to
62c54e5
Compare
joshuay03
changed the title
:through associations
joshuay03
commented
Jul 3, 2025
| has_one :location, class_name: "Country" | ||
| belongs_to :location, class_name: "Country" |
There was a problem hiding this comment.
Going off of the schema I'm pretty sure this was incorrectly set up, as I don't see any tests that expect this to be invalid.
joshuay03
force-pushed
the
through-association-support
branch
from
62c54e5 to
631ee7e
Compare
joshuay03
commented
Jul 3, 2025
| end | ||
| RUBY | ||
|
|
||
| assert_equal(2, response.size) |
joshuay03
commented
Jul 3, 2025
| end | ||
| RUBY | ||
|
|
||
| assert_equal(2, response.size) |
vinistock
reviewed
Jul 16, 2025
Comment on lines
+113
to
+119
| through_association_name = node.arguments.arguments | ||
| .filter_map { |arg| arg.elements if arg.is_a?(Prism::KeywordHashNode) } | ||
| .flatten | ||
| .find { |elem| elem.key.value == "through" } | ||
| &.value | ||
| &.unescaped | ||
| handle_association_name(through_association_name) if through_association_name |
There was a problem hiding this comment.
Just to understand the intended experience, when going to definition you'd see both the association and the through association as options, correct?
Also, the node.arguments return is nilable for when there are no arguments. I think we can restructure this a bit.
- At the top of the
handle_associationmethod, we can get the arguments and return early if it's nil.
arguments = node.arguments&.arguments
return unless arguments- Then you can reuse the same arguments array for checking the first argument and the
through
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, clicking on the through association name goes to the same file as the association name. I've added explicit support to navigate to the correct through association model file.