Speed up workspace symbol search by filtering before fuzzy matching

[janko]

Motivation

Closes #2660

I want workspace symbol searches to be faster so that I use them more often in my code editor.

Implementation

Currently, fuzzy matching is performed on all symbols, and then dependency/private entries are filtered out. With the assumption that filtering is faster than fuzzy matching, I flipped this around, by first filtering out dependency/private entires, and then doing the fuzzy matching on the remainder.

This turns out to be ~2-4x faster in my benchmarks.

Automated Tests

I didn't update automated tests.

[graphite-app]

How to use the Graphite Merge Queue

Add the label graphite-merge to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

[vinistock]

The insight that we can filter entries before comparing definitely makes sense and we should try to do it.

That said, I'm not sure we need raw_path when path already exists and skipping the to_standardized_path conversions might produce incorrect results on Windows.

[janko]

@vinistock As proposed in #3806 (comment), I removed the URI::Generic#to_standardized_path optimizations and kept only doing filtering before fuzzy matching.

Contrary to my initial benchmarks, this change alone seems to provide a ~2-4x speedup, so it does make sense on its own 🙂

[vinistock]

Thanks for the contribution!