Skip to content

Shopify Graphql Api does not leverage AbortSignal as described #2643

@shawngrona

Description

@shawngrona

Issue summary

There were several prs which mentioned passing through the fetch signal property such that clients can set their own timeouts and abort the request for retrying. This is extremely important bc we intermittently see Shopify requests taking 30, 40 seconds and then finally 503 response. We don't want to wait that long, we want to be able to timeout in a few seconds and backoff/retry.

Here are a couple commits where this functionality was added

bf7cf8b

ada2cc3

Its also mentioned in your documentation

https://github.com/Shopify/shopify-app-js/blob/main/packages/apps/shopify-api/docs/reference/clients/Graphql.md

To me it looks like the @shopify/admin-api is still referenced as 1.1 in your latest @shopify/shopify-api, and the admin-api with this functionality is in higher versions (maybe 1.5 or 1.8 I can't quite tell)

When will this functionality be generally available and in what version?

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions