Show skipped gem RBI generation

Author: written-fresh

lib/tapioca/commands/abstract_gem.rb

@@ -71,6 +71,7 @@ def initialize(
         @include_doc = include_doc #: bool
         @include_loc = include_loc #: bool
         @include_exported_rbis = include_exported_rbis
+        @skipped_gems = [] #: Array[String]
         @halt_upon_load_error = halt_upon_load_error
       end
 

lib/tapioca/commands/gem_generate.rb

@@ -17,7 +17,8 @@ def execute
           halt_upon_load_error: @halt_upon_load_error,
         )
 
-        gem_queue = gems_to_generate(@gem_names).reject { |gem| @exclude.include?(gem.name) }
+        gem_queue = gems_to_generate(@gem_names)
+        gem_queue.reject! { |gem| @exclude.include?(gem.name) }
         anything_done = [
           perform_removals,
           gem_queue.any?,
@@ -30,6 +31,17 @@ def execute
           end
         end
 
+        user_excluded_gems = @gem_names & @exclude
+
+        unless @skipped_gems.empty?
+          say("\nNote: Tapioca skipped RBI generation for the following gems because they are ignored by default:", [:yellow, :bold])
+          say(@skipped_gems.join(", "), [:yellow, :bold])
+        end
+        unless user_excluded_gems.empty?
+          say("\nNote: Tapioca skipped RBI generation for the following gems because they were excluded:", [:yellow, :bold])
+          say(user_excluded_gems.join(", "), [:yellow, :bold])
+        end
+
         if anything_done
           validate_rbi_files(
             command: default_command(:gem, @gem_names.join(" ")),
@@ -52,15 +64,19 @@ def execute
       def gems_to_generate(gem_names)
         return @bundle.dependencies if gem_names.empty?
 
-        (gem_names - @exclude).each_with_object([]) do |gem_name, gems|
+        gem_names.each_with_object([]) do |gem_name, gems|
           gem = @bundle.gem(gem_name)
 
           if gem.nil?
-            next if @lsp_addon
-
-            raise Tapioca::Error, set_color("Error: Cannot find gem '#{gem_name}'", :red)
+            if @lsp_addon
+              next
+            elsif Gemfile::GemSpec::IGNORED_GEMS.include?(gem_name)
+              @skipped_gems << gem_name
+              next
+            else
+              raise Tapioca::Error, set_color("Error: Cannot find gem '#{gem_name}'", :red)
+            end
           end
-
           gems.concat(gem_dependencies(gem)) if @include_dependencies
           gems << gem
         end

spec/tapioca/cli/gem_spec.rb

@@ -877,6 +877,67 @@ class Secret; end
           assert_success_status(result)
         end
 
+        it "reports explicitly requested ignored gems" do
+          result = @project.tapioca("gem sorbet", exclude: [])
+
+          assert_stdout_includes(result, <<~OUT)
+            Note: Tapioca skipped RBI generation for the following gems because they are ignored by default:
+            sorbet
+          OUT
+          refute_includes(result.out, "Compiled sorbet")
+
+          assert_empty_stderr(result)
+          assert_success_status(result)
+        end
+
+        it "reports gems excluded by built-in and user configuration" do
+          result = @project.tapioca("gem sorbet rbi --exclude rbi")
+
+          assert_stdout_includes(result, <<~OUT)
+            Note: Tapioca skipped RBI generation for the following gems because they are ignored by default:
+            sorbet
+          OUT
+          assert_stdout_includes(result, <<~OUT)
+            Note: Tapioca skipped RBI generation for the following gems because they were excluded:
+            rbi
+          OUT
+          refute_includes(result.out, "Compiled rbi")
+
+          assert_empty_stderr(result)
+          assert_success_status(result)
+        end
+
+        it "reports gems excluded by user configuration" do
+          result = @project.tapioca("gem rbi --exclude rbi")
+
+          assert_stdout_includes(result, <<~OUT)
+            Note: Tapioca skipped RBI generation for the following gems because they were excluded:
+            rbi
+          OUT
+          refute_includes(result.out, "Compiled rbi")
+
+          assert_empty_stderr(result)
+          assert_success_status(result)
+        end
+
+        it "does not report exclusions when no gems are explicitly requested" do
+          result = @project.tapioca("gem --exclude rbi")
+
+          refute_includes(result.out, "because they were excluded")
+
+          assert_empty_stderr(result)
+          assert_success_status(result)
+        end
+
+        it "does not report exclusions when all gems are requested" do
+          result = @project.tapioca("gem --all --exclude rbi")
+
+          refute_includes(result.out, "because they were excluded")
+
+          assert_empty_stderr(result)
+          assert_success_status(result)
+        end
+
         it "fails with error when gem cannot be found" do
           result = @project.tapioca("gem non_existent_gem")