Show startup error when tracker server port is in use (#1596)

Author: ImSapphire

server/android/src/main/java/dev/slimevr/android/Main.kt

@@ -9,6 +9,7 @@ import dev.slimevr.Keybinding
 import dev.slimevr.VRServer
 import dev.slimevr.android.serial.AndroidSerialHandler
 import dev.slimevr.android.tracking.trackers.hid.AndroidHIDManager
+import dev.slimevr.config.ConfigManager
 import dev.slimevr.tracking.trackers.Tracker
 import io.eiren.util.logging.LogManager
 import io.ktor.http.CacheControl
@@ -51,8 +52,12 @@ fun main(activity: AppCompatActivity) {
 		}
 
 		try {
+			val configPath = File(activity.filesDir, "vrconfig.yml").absolutePath
+			val configManager = ConfigManager(configPath)
+			configManager.loadConfig()
+
 			vrServer = VRServer(
-				configPath = File(activity.filesDir, "vrconfig.yml").absolutePath,
+				configManager = configManager,
 				serialHandlerProvider = { _ -> AndroidSerialHandler(activity) },
 				acquireMulticastLock = {
 					val wifi = activity.getSystemService(Context.WIFI_SERVICE) as WifiManager

server/core/src/main/java/dev/slimevr/VRServer.kt

@@ -56,13 +56,9 @@ class VRServer @JvmOverloads constructor(
 	flashingHandlerProvider: (VRServer) -> SerialFlashingHandler? = { _ -> null },
 	vrcConfigHandlerProvider: (VRServer) -> VRCConfigHandler = { _ -> VRCConfigHandlerStub() },
 	acquireMulticastLock: () -> Any? = { null },
-	// configPath is used by VRWorkout, do not remove!
-	configPath: String,
+	@JvmField val configManager: ConfigManager,
 ) : Thread("VRServer") {
 
-	@JvmField
-	val configManager: ConfigManager
-
 	@JvmField
 	val humanPoseManager: HumanPoseManager
 	private val trackers: MutableList<Tracker> = FastList()
@@ -119,8 +115,6 @@ class VRServer @JvmOverloads constructor(
 
 	init {
 		// UwU
-		configManager = ConfigManager(configPath)
-		configManager.loadConfig()
 		deviceManager = DeviceManager(this)
 		serialHandler = serialHandlerProvider(this)
 		serialFlashingHandler = flashingHandlerProvider(this)

server/desktop/src/main/java/dev/slimevr/desktop/Main.kt

@@ -6,6 +6,7 @@ import dev.slimevr.Keybinding
 import dev.slimevr.SLIMEVR_IDENTIFIER
 import dev.slimevr.VRServer
 import dev.slimevr.bridge.Bridge
+import dev.slimevr.config.ConfigManager
 import dev.slimevr.desktop.firmware.DesktopSerialFlashingHandler
 import dev.slimevr.desktop.games.vrchat.DesktopVRCConfigHandler
 import dev.slimevr.desktop.platform.SteamVRBridge
@@ -27,6 +28,7 @@ import org.apache.commons.lang3.SystemUtils
 import java.io.File
 import java.io.IOException
 import java.lang.System
+import java.net.DatagramSocket
 import java.net.ServerSocket
 import java.nio.file.Files
 import java.nio.file.Paths
@@ -96,36 +98,38 @@ fun main(args: Array<String>) {
 		LogManager.closeLogger()
 		return
 	}
+
+	val configDir = resolveConfig()
+	LogManager.info("Using config dir: $configDir")
+
+	val configManager = ConfigManager(configDir)
+	configManager.loadConfig()
+
 	try {
-		// This is disabled because the config can't be read at this point
-		// ServerSocket(6969).close()
+		DatagramSocket(configManager.vrConfig.server.trackerPort).close()
 		ServerSocket(21110).close()
 	} catch (e: IOException) {
+		val message = "SlimeVR start-up error! A required port (${configManager.vrConfig.server.trackerPort} and 21110) is busy. " +
+			"Make sure there is no other instance of SlimeVR Server running."
 		LogManager
-			.severe(
-				"SlimeVR start-up error! Required ports are busy. " +
-					"Make sure there is no other instance of SlimeVR Server running.",
-			)
+			.severe(message)
 		JOptionPane
 			.showMessageDialog(
 				null,
-				"SlimeVR start-up error! Required ports are busy. " +
-					"Make sure there is no other instance of SlimeVR Server running.",
+				message,
 				"SlimeVR: Ports are busy",
 				JOptionPane.ERROR_MESSAGE,
 			)
 		LogManager.closeLogger()
 		return
 	}
 	try {
-		val configDir = resolveConfig()
-		LogManager.info("Using config dir: $configDir")
 		val vrServer = VRServer(
 			::provideBridges,
 			{ _ -> DesktopSerialHandler() },
 			{ _ -> DesktopSerialFlashingHandler() },
 			{ _ -> DesktopVRCConfigHandler() },
-			configPath = configDir,
+			configManager = configManager,
 		)
 		vrServer.start()