fix preference error

Author: SharonStrats

src/lib/preferences.js

@@ -69,6 +69,10 @@ export function recordSharedPreferences (subject, context) {
 //
 export function recordPersonalDefaults (theClass, context) {
   return new Promise(function (resolve, reject) {
+    if (!context.me) {
+      resolve(context)
+      return
+    }
     ensureLoadedPreferences(context).then(
       context => {
         if (!context.preferencesFile) {

src/login/login.ts

@@ -1053,7 +1053,11 @@ export function newAppInstance (
  */
 export async function getUserRoles (): Promise<Array<NamedNode>> {
   try {
-    const { me, preferencesFile, preferencesFileError } = await ensureLoadedPreferences({})
+    const me = authn.currentUser()
+    if (!me) {
+      return []
+    }
+    const { preferencesFile, preferencesFileError } = await ensureLoadedPreferences({})
     if (!preferencesFile || preferencesFileError) {
       throw new Error(preferencesFileError)
     }

test/unit/preferences.test.ts

@@ -1,6 +1,11 @@
-import { describe, expect, it } from 'vitest'
+import { describe, expect, it, vi } from 'vitest'
 import { silenceDebugMessages } from './helpers/debugger'
 import { JSDOM } from 'jsdom'
+vi.mock('../../src/login/login', () => ({
+  ensureLoadedPreferences: vi.fn()
+}))
+
+import * as loginModule from '../../src/login/login'
 import * as Preferences from '../../src/lib/preferences'
 import { sym } from 'rdflib'
 
@@ -64,6 +69,18 @@ describe('Preferences.recordSharedPreferences', () => {
   })
 })
 
+describe('Preferences.recordPersonalDefaults', () => {
+  it('does not try to load preferences when there is no logged-in user', async () => {
+    const ensureLoadedPreferencesMock = vi.mocked(loginModule.ensureLoadedPreferences)
+
+    const context = { me: null }
+    const result = await Preferences.recordPersonalDefaults('https://test.example/class', context)
+
+    expect(result).toBe(context)
+    expect(ensureLoadedPreferencesMock).not.toHaveBeenCalled()
+  })
+})
+
 describe('Preferences.getPreferencesForClass', () => {
   it('exists', () => {
     expect(Preferences.getPreferencesForClass).toBeInstanceOf(Function)