SONARJAVA-5741 Stop using org.apache.commons.lang3.StringUtils::isEmpty

Author: tomasz-tylenda-sonarsource

java-checks/src/main/java/org/sonar/java/checks/AbstractHardCodedCredentialChecker.java

@@ -23,8 +23,8 @@
 import java.util.regex.Matcher;
 import java.util.regex.Pattern;
 import java.util.stream.Stream;
-import org.apache.commons.lang3.StringUtils;
 import org.sonar.java.checks.helpers.ExpressionsHelper;
+import org.sonar.java.checks.helpers.StringUtils;
 import org.sonar.java.model.LiteralUtils;
 import org.sonar.plugins.java.api.IssuableSubscriptionVisitor;
 import org.sonar.plugins.java.api.semantic.MethodMatchers;

java-checks/src/main/java/org/sonar/java/checks/DisallowedConstructorCheck.java

@@ -16,9 +16,9 @@
  */
 package org.sonar.java.checks;
 
-import org.apache.commons.lang3.StringUtils;
 import org.sonar.check.Rule;
 import org.sonar.check.RuleProperty;
+import org.sonar.java.checks.helpers.StringUtils;
 import org.sonar.java.checks.methods.AbstractMethodDetection;
 import org.sonar.plugins.java.api.semantic.MethodMatchers;
 import org.sonar.plugins.java.api.tree.NewClassTree;

java-checks/src/main/java/org/sonar/java/checks/DisallowedMethodCheck.java

@@ -16,9 +16,9 @@
  */
 package org.sonar.java.checks;
 
-import org.apache.commons.lang3.StringUtils;
 import org.sonar.check.Rule;
 import org.sonar.check.RuleProperty;
+import org.sonar.java.checks.helpers.StringUtils;
 import org.sonar.java.checks.methods.AbstractMethodDetection;
 import org.sonar.java.model.ExpressionUtils;
 import org.sonar.plugins.java.api.semantic.MethodMatchers;

java-checks/src/main/java/org/sonar/java/checks/UndocumentedApiCheck.java

@@ -21,12 +21,12 @@
 import java.util.Set;
 import java.util.regex.Pattern;
 import java.util.stream.Collectors;
-import org.apache.commons.lang3.StringUtils;
 import org.sonar.api.utils.WildcardPattern;
 import org.sonar.check.Rule;
 import org.sonar.check.RuleProperty;
 import org.sonar.java.ast.visitors.PublicApiChecker;
 import org.sonar.java.checks.helpers.Javadoc;
+import org.sonar.java.checks.helpers.StringUtils;
 import org.sonar.java.model.PackageUtils;
 import org.sonar.plugins.java.api.JavaFileScanner;
 import org.sonar.plugins.java.api.JavaFileScannerContext;

java-checks/src/main/java/org/sonar/java/checks/helpers/StringUtils.java

@@ -26,6 +26,11 @@ public static boolean isEmpty(@Nullable String s) {
     return s == null || s.isEmpty();
   }
 
+  /** Opposite of {@link #isEmpty(String)}. */
+  public static boolean isNotEmpty(@Nullable String s) {
+    return !isEmpty(s);
+  }
+
   /** Count non-overlapping occurrences of <code>pattern</code> in the <code>string</code>. */
   public static int countMatches(@Nullable String string, @Nullable String pattern) {
     if (isEmpty(string) || isEmpty(pattern)) {
@@ -41,4 +46,13 @@ public static int countMatches(@Nullable String string, @Nullable String pattern
 
     return count;
   }
+
+  /**
+   * Calls {@link org.apache.commons.lang3.StringUtils#split(String, String)}.
+   *
+   * <p>This method exists to avoid name clash between two <code>StringUtils</code> classes.
+   */
+  public static String[] split(String string, String separator) {
+    return org.apache.commons.lang3.StringUtils.split(string, separator);
+  }
 }

java-checks/src/main/java/org/sonar/java/checks/tests/AssertionsInTestsCheck.java

@@ -42,7 +42,7 @@
 import org.sonar.plugins.java.api.tree.Modifier;
 import org.sonar.plugins.java.api.tree.Tree;
 
-import static org.apache.commons.lang3.StringUtils.isEmpty;
+import static org.sonar.java.checks.helpers.StringUtils.isEmpty;
 import static org.sonar.java.checks.helpers.UnitTestUtils.isUnitTest;
 
 @Rule(key = "S2699")