Skip to content

SLCORE-1631 Avoid running analysis on test failure #1543

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 6, 2025
Merged

SLCORE-1631 Avoid running analysis on test failure #1543

merged 2 commits into from
Nov 6, 2025

Conversation

@eray-felek-sonarsource
Copy link
Contributor

@eray-felek-sonarsource eray-felek-sonarsource commented Oct 24, 2025 •
edited by atlassian bot
Loading

@eray-felek-sonarsource eray-felek-sonarsource marked this pull request as ready for review October 24, 2025 12:08
damien-urruty-sonarsource
damien-urruty-sonarsource reviewed Oct 24, 2025
View reviewed changes
Copy link
Contributor

@damien-urruty-sonarsource damien-urruty-sonarsource left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand why the analysis was triggered in case of failed tests with the previous implementation. Even in the official documentation, both verify and sonar goals are triggered in the same mvn command. Did you understand why?

@eray-felek-sonarsource eray-felek-sonarsource force-pushed the feature/ef/SLCORE-1631-avoid-running-analysis-on-failure branch 2 times, most recently from b394547 to bb05e43 Compare November 6, 2025 10:21
@eray-felek-sonarsource eray-felek-sonarsource force-pushed the feature/ef/SLCORE-1631-avoid-running-analysis-on-failure branch from bb05e43 to 7d59dfb Compare November 6, 2025 12:05
@sonarqube-next
Copy link

sonarqube-next bot commented Nov 6, 2025

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
0 Dependency risks
No data about Coverage
No data about Duplication

See analysis details on SonarQube

@eray-felek-sonarsource eray-felek-sonarsource merged commit e077038 into master Nov 6, 2025
20 of 21 checks passed
@eray-felek-sonarsource eray-felek-sonarsource deleted the feature/ef/SLCORE-1631-avoid-running-analysis-on-failure branch November 6, 2025 12:54
kirill-knize-sonarsource pushed a commit that referenced this pull request Nov 7, 2025
@eray-felek-sonarsource @kirill-knize-sonarsource
SLCORE-1631 Avoid running analysis on test failure (#1543)
b937571 
* SLCORE-1631 Avoid running analysis on test failure

* Rever the test case
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@damien-urruty-sonarsource damien-urruty-sonarsource damien-urruty-sonarsource approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@eray-felek-sonarsource @damien-urruty-sonarsource