Refactor ScreenManager for improved command execution

- Remove screen:run command

Author: chapterjason

.github/workflows/ci.yml

@@ -100,6 +100,7 @@ jobs:
                     php-version: 8.4
                     tools: infection
             -   uses: ramsey/composer-install@v3
-            -   run: infection --min-msi=53 --min-covered-msi=95 --threads=4
+            -   run: |
+                    infection --min-msi=32 --min-covered-msi=59 "--threads=$(nproc)"
                 env:
                     STRYKER_DASHBOARD_API_KEY: ${{ secrets.STRYKER_DASHBOARD_API_KEY }}

README.md

@@ -60,4 +60,8 @@ soure_code_screen:
       command: [ "php", "bin/console", "messenger:consume", "async", "--limit", "10", "-vv" ]
     worker1:
       command: [ "php", "bin/console", "messenger:consume", "async", "--limit", "10", "-vv" ]
-```
+```
+
+## Development
+
+**Note:** To run infection threaded the tests are written to be random, this causes to generate a lot of log files in the `tests/app/var/log` directory.

composer.json

@@ -11,7 +11,6 @@
     ],
     "require": {
         "php": ">=8.3",
-        "ext-pcntl": "*",
         "psr/log": "^3.0",
         "symfony/config": "^7.1",
         "symfony/console": "^7.1",

phpstan-baseline.neon

@@ -7,19 +7,19 @@ parameters:
 			path: tests/BundleInitializationTest.php
 
 		-
-			message: '#^Method SoureCode\\Bundle\\Screen\\Tests\\Manager\\ScreenManagerTest\:\:createKernel\(\) has parameter \$options with no value type specified in iterable type array\.$#'
-			identifier: missingType.iterableValue
+			message: '#^Parameter \#1 \$baseDirectory of class SoureCode\\Bundle\\Screen\\Manager\\ScreenManager constructor expects string, string\|false given\.$#'
+			identifier: argument.type
 			count: 1
 			path: tests/Manager/ScreenManagerTest.php
 
 		-
-			message: '#^Method SoureCode\\Bundle\\Screen\\Tests\\Manager\\ScreenManagerTest\:\:getScreenManager\(\) should return SoureCode\\Bundle\\Screen\\Manager\\ScreenManager but returns object\.$#'
-			identifier: return.type
+			message: '#^Parameter \#2 \$haystack of method PHPUnit\\Framework\\Assert\:\:assertStringContainsString\(\) expects string, string\|null given\.$#'
+			identifier: argument.type
 			count: 1
 			path: tests/Manager/ScreenManagerTest.php
 
 		-
-			message: '#^Parameter \#2 \$haystack of method PHPUnit\\Framework\\Assert\:\:assertStringContainsString\(\) expects string, string\|null given\.$#'
+			message: '#^Parameter \#2 \$screenDefinitions of class SoureCode\\Bundle\\Screen\\Provider\\ArrayScreenProvider constructor expects array\<string, array\{command\: list\<string\>\}\>, array\{echoTest\: array\{command\: array\{''echo'', string\}\}, daemonTest\: array\{command\: array\{''sleep'', int\}\}\} given\.$#'
 			identifier: argument.type
 			count: 1
 			path: tests/Manager/ScreenManagerTest.php

scripts/ci.sh

@@ -19,6 +19,9 @@ kyx composer-unused
 FORCED_PHP_VERSION=8.3 kyx php-cs-fixer fix --dry-run --show-progress=dots --using-cache=no --verbose
 kyx phpstan analyse --memory-limit=512M --ansi --no-progress --error-format=table
 vendor/bin/phpunit
-kyx infection "-j$(nproc)"
+kyx infection "--threads=$(nproc)"
+
+# clear logs
+rm -r "${PROJECT_DIRECTORY}/tests/app/var/log" || true
 
 popd >/dev/null