New communication in v19 broke a feature

[kimlongcr]

Description

Prior to version 19, the Communication Entry Wizard had a block setting to determine which communication preference you wanted to expose - Recipient Preference, SMS or email. We had it set to only expose Recipient Preference and Email.

Actual Behavior

Now, the block setting didn't change but it is no longer using the block setting and displays all three if you choose Recipient Preference.

Expected Behavior

It uses what is set on the block setting.

Why is this so important? With the strict opt in laws for texting, our users should never be sending an SMS only option. They should be using the recipient preference or email only. By allowing SMS only, it is opening us to a potential lawsuit (we are already in one now for something very similar). And, while I would love to believe that no one will ever choose SMS because we train them not to, the reality is they will.

Steps to Reproduce

Go to here: https://rockdev.crossroads.net/Communication/
Set the block setting to recipient preference = recipient preference, email and SMS display

Issue Confirmation

• Perform a search on the Github Issues to see if your bug is already reported.
• Reproduced the problem on a fresh install or on the demo site.

Rock Version

Rock McKinley 18.2 (18.2.4)

Client Culture Setting

en-US