Added ChildRenderer support #654
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
Tried this , check and see does it work as expected .. |
Owner
|
@Anu27n First of all thanks! Please let me know when you plan to create a large PR like this. I'm already working with a new renderer and when I will finish with it I would add also childs support. I'm afraid that you current implementation it does not use deferred contexts which will cause a lot of issues. I will try to review this but timing is not good as a lot of changes have been made so far on the renderer. |
Author
|
@SuRGeoNix Ah okay, got it. I’ll wait for your renderer updates to be merged first, and then revisit this part accordingly. You can review this PR just as a sample/reference for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.