Skip to content

Commit 1452465

Browse files
committed
fix: put back docstrings for launching sessions
1 parent d01d07e commit 1452465

File tree

2 files changed

+60
-1
lines changed

2 files changed

+60
-1
lines changed

renku_notebooks/__init__.py

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,6 +27,7 @@
2727
check_docker_image,
2828
launch_notebook,
2929
patch_server,
30+
renku_2_launch_notebook_helper,
3031
server_logs,
3132
server_options,
3233
stop_server,
@@ -38,7 +39,7 @@
3839
from .api.schemas.logs import ServerLogs
3940
from .api.schemas.servers_get import NotebookResponse, ServersGetRequest, ServersGetResponse
4041
from .api.schemas.servers_patch import PatchServerRequest
41-
from .api.schemas.servers_post import LaunchNotebookRequest
42+
from .api.schemas.servers_post import LaunchNotebookRequest, Renku2LaunchNotebookRequest
4243
from .api.schemas.version import VersionResponse
4344
from .config import config as config
4445
from .errors.utils import handle_exception
@@ -130,6 +131,7 @@ def register_swagger(app):
130131
)
131132
# Register schemas
132133
spec.components.schema("LaunchNotebookRequest", schema=LaunchNotebookRequest)
134+
spec.components.schema("Renku2LaunchNotebookRequest", schema=Renku2LaunchNotebookRequest)
133135
spec.components.schema("NotebookResponse", schema=NotebookResponse)
134136
spec.components.schema("PatchServerRequest", schema=PatchServerRequest)
135137
spec.components.schema("ServersGetRequest", schema=ServersGetRequest)
@@ -148,6 +150,7 @@ def register_swagger(app):
148150
spec.path(view=server_options)
149151
spec.path(view=server_logs)
150152
spec.path(view=check_docker_image)
153+
spec.path(view=renku_2_launch_notebook_helper)
151154
# Register security scheme
152155
security_scheme = {
153156
"type": "openIdConnect",

renku_notebooks/api/notebooks.py

Lines changed: 56 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -194,6 +194,34 @@ def launch_notebook(
194194
server_options=None,
195195
user_secrets=None,
196196
):
197+
"""Launch a Jupyter server.
198+
199+
---
200+
post:
201+
description: Start a server.
202+
requestBody:
203+
content:
204+
application/json:
205+
schema: LaunchNotebookRequest
206+
responses:
207+
200:
208+
description: The server exists and is already running.
209+
content:
210+
application/json:
211+
schema: NotebookResponse
212+
201:
213+
description: The requested server has been created.
214+
content:
215+
application/json:
216+
schema: NotebookResponse
217+
404:
218+
description: The server could not be launched.
219+
content:
220+
application/json:
221+
schema: ErrorResponse
222+
tags:
223+
- servers
224+
"""
197225
server_name = renku_1_make_server_name(user.safe_username, namespace, project, branch, commit_sha)
198226
gl_project = user.get_renku_project(f"{namespace}/{project}")
199227
gl_project_path = gl_project.path
@@ -244,6 +272,34 @@ def renku_2_launch_notebook_helper(
244272
launcher_id: str | None = None, # Renku 2
245273
repositories: list[dict[str, str]] | None = None, # Renku 2
246274
):
275+
"""Launch a Jupyter server using the new API.
276+
277+
---
278+
post:
279+
description: Start a server.
280+
requestBody:
281+
content:
282+
application/json:
283+
schema: Renku2LaunchNotebookRequest
284+
responses:
285+
200:
286+
description: The server exists and is already running.
287+
content:
288+
application/json:
289+
schema: NotebookResponse
290+
201:
291+
description: The requested server has been created.
292+
content:
293+
application/json:
294+
schema: NotebookResponse
295+
404:
296+
description: The server could not be launched.
297+
content:
298+
application/json:
299+
schema: ErrorResponse
300+
tags:
301+
- servers
302+
"""
247303
server_name = renku_2_make_server_name(
248304
safe_username=user.safe_username, project_id=project_id, launcher_id=launcher_id
249305
)

0 commit comments

Comments
 (0)