add test for utils.dict2object

Author: TTWShell

hobbit_core/flask_hobbit/utils.py

@@ -10,7 +10,7 @@ class dict2object(dict):
 
     Examples::
 
-        In [2]: obj = dict2object({'a':2, 'c':3})
+        In [2]: obj = dict2object({'a': 2, 'c': 3})
 
         In [3]: obj.a
         Out[3]: 2
@@ -32,7 +32,7 @@ def __setattr__(self, name, value):
 
 
 def secure_filename(filename):
-    """Borrowed from werkzeug.utils.secure_filename. Python3 only.
+    """Borrowed from werkzeug.utils.secure_filename. **Python3 only**.
 
     Pass it a filename and it will return a secure version of it. This
     filename can then safely be stored on a regular file system and passed
@@ -70,7 +70,7 @@ def secure_filename(filename):
         'LPT2', 'LPT3', 'PRN', 'NUL',
     )
     if os.name == 'nt' and filename and \
-       filename.split('.')[0].upper() in windows_device_files:
+            filename.split('.')[0].upper() in windows_device_files:
         filename = '_' + filename
 
     return filename

tests/test_utils.py

@@ -1,11 +1,26 @@
 # -*- encoding: utf-8 -*-
-from hobbit_core.flask_hobbit.utils import secure_filename
+import pytest
+
+from hobbit_core.flask_hobbit import utils
 
 from . import BaseTest, python3_only
 
 
 class TestUtils(BaseTest):
 
+    def test_dict2object(self):
+        obj = utils.dict2object({'a': 2, 'c': 3})
+        assert obj.a == 2
+        assert obj.c == 3
+
+        # test setattr
+        obj.a = 4
+        assert obj.a == 4
+
+        # test getattr
+        with pytest.raises(AttributeError):
+            print(obj.b)
+
     @python3_only
     def test_secure_filename(self):
         filenames = (
@@ -19,4 +34,4 @@ def test_secure_filename(self):
             'i_contain_cool_umlauts.txt',
         )
         for i, filename in enumerate(filenames):
-            assert secure_filename(filename) == excepted[i]
+            assert utils.secure_filename(filename) == excepted[i]