[Bug]: File Duration Label Non-Functional #1037
Description
Checklist
- I am using an up-to-date version.
- I have read the documentation.
- I have searched existing issues.
TagStudio Version
Alpha 9.5.3
Operating System & Version
macOS 15.5
Description
The file duration label (length in time for audio files and videos) in the preview panel appears to be non-functional as of 9.5.3 and shows a blank spot instead of the correct label (on first click only):
Then when clicking the same file thumbnail again, a widely incorrect duration is now shown:
Note: I caught this while preparing the release of 9.5.3 but wasn't able to get it functioning myself in time for the patch. I believe I've traced this back to #952, but the apparent cause and solution to this bug are not so straightforward. My impression is that this is caused by a potential race condition when loading a media file for the preview panel. This is indicated by the fact that clicking the file again properly loads the movie's length as something other than "0" internally, and how in my tests that moving the length check to a later part in the code started to produce positive values some of the time on the first try. The wildly high values on the other hand I haven't looked into too deeply yet.
As a minor knock-on effect, it appears that a duration value of "0" breaks the string formatting and just causes the final line to be blank. This, in comparison, is an easy fix that just requires that edge case to be fixed. I decided not to push this fix before the patch as to give "no information over false information" about the file duration.
Expected Behavior
The correct duration of audio and video files should show in the preview panel, as they did in 9.5.2.
Steps to Reproduce
- Open a TagStudio library with audio and/or video files
- Click on one of these file thumbnails to inspect it in the preview panel and see the empty space where the duration belongs
Logs
N/A