chore(eslint): set array-type lint rule to generic (#5899)

* chore(eslint): set array-type lint rule to generic

* chore: fix prettier

Author: TkDodo

.eslintrc.cjs

@@ -34,6 +34,7 @@ const config = {
     },
   },
   rules: {
+    '@typescript-eslint/array-type': ['error', { default: 'generic', readonly: 'generic' }],
     '@typescript-eslint/ban-types': 'off',
     '@typescript-eslint/ban-ts-comment': 'off',
     '@typescript-eslint/consistent-type-imports': [

packages/codemods/src/v4/__testfixtures__/type-arguments.input.tsx

@@ -2,10 +2,10 @@ import * as React from 'react'
 import { useQueries, useQuery, useQueryClient } from 'react-query'
 
 type Todos = {
-  items: readonly {
+  items: ReadonlyArray<{
     id: string
     text: string
-  }[]
+  }>
   ts: number
 }
 

packages/codemods/src/v4/__testfixtures__/type-arguments.output.tsx

@@ -2,10 +2,10 @@ import * as React from 'react'
 import { useQueries, useQuery, useQueryClient } from 'react-query'
 
 type Todos = {
-  items: readonly {
+  items: ReadonlyArray<{
     id: string
     text: string
-  }[]
+  }>
   ts: number
 }
 

packages/eslint-plugin-query/src/rules/exhaustive-deps.utils.ts

@@ -4,7 +4,7 @@ import type { TSESLint } from '@typescript-eslint/utils'
 
 export const ExhaustiveDepsUtils = {
   isRelevantReference(params: {
-    context: Readonly<TSESLint.RuleContext<string, readonly unknown[]>>
+    context: Readonly<TSESLint.RuleContext<string, ReadonlyArray<unknown>>>
     reference: TSESLint.Scope.Reference
     scopeManager: TSESLint.Scope.ScopeManager
   }) {

packages/eslint-plugin-query/src/utils/ast-utils.ts

@@ -7,7 +7,7 @@ import type { RuleContext } from '@typescript-eslint/utils/dist/ts-eslint'
 export const ASTUtils = {
   isNodeOfOneOf<T extends AST_NODE_TYPES>(
     node: TSESTree.Node,
-    types: readonly T[],
+    types: ReadonlyArray<T>,
   ): node is TSESTree.Node & { type: T } {
     return types.includes(node.type as T)
   },
@@ -20,7 +20,7 @@ export const ASTUtils = {
   ): node is TSESTree.Identifier {
     return ASTUtils.isIdentifier(node) && node.name === name
   },
-  isIdentifierWithOneOfNames<T extends string[]>(
+  isIdentifierWithOneOfNames<T extends Array<string>>(
     node: TSESTree.Node,
     name: T,
   ): node is TSESTree.Identifier & { name: T[number] } {
@@ -41,15 +41,15 @@ export const ASTUtils = {
     )
   },
   findPropertyWithIdentifierKey(
-    properties: TSESTree.ObjectLiteralElement[],
+    properties: Array<TSESTree.ObjectLiteralElement>,
     key: string,
   ): TSESTree.Property | undefined {
     return properties.find((x) =>
       ASTUtils.isPropertyWithIdentifierKey(x, key),
     ) as TSESTree.Property | undefined
   },
-  getNestedIdentifiers(node: TSESTree.Node): TSESTree.Identifier[] {
-    const identifiers: TSESTree.Identifier[] = []
+  getNestedIdentifiers(node: TSESTree.Node): Array<TSESTree.Identifier> {
+    const identifiers: Array<TSESTree.Identifier> = []
 
     if (ASTUtils.isIdentifier(node)) {
       identifiers.push(node)
@@ -131,7 +131,7 @@ export const ASTUtils = {
   },
   traverseUpOnly(
     identifier: TSESTree.Node,
-    allowedNodeTypes: AST_NODE_TYPES[],
+    allowedNodeTypes: Array<AST_NODE_TYPES>,
   ): TSESTree.Node {
     const parent = identifier.parent
 
@@ -159,7 +159,7 @@ export const ASTUtils = {
     scopeManager: TSESLint.Scope.ScopeManager
     sourceCode: Readonly<TSESLint.SourceCode>
     node: TSESTree.Node
-  }): TSESLint.Scope.Reference[] {
+  }): Array<TSESLint.Scope.Reference> {
     const { scopeManager, sourceCode, node } = params
     const scope = scopeManager.acquire(node)
 
@@ -207,7 +207,7 @@ export const ASTUtils = {
     return identifier !== null && /^(use|[A-Z])/.test(identifier.name)
   },
   getFunctionAncestor(
-    context: Readonly<RuleContext<string, readonly unknown[]>>,
+    context: Readonly<RuleContext<string, ReadonlyArray<unknown>>>,
   ) {
     return context.getAncestors().find((x) => {
       if (x.type === AST_NODE_TYPES.FunctionDeclaration) {
@@ -227,7 +227,7 @@ export const ASTUtils = {
   },
   getReferencedExpressionByIdentifier(params: {
     node: TSESTree.Node
-    context: Readonly<RuleContext<string, readonly unknown[]>>
+    context: Readonly<RuleContext<string, ReadonlyArray<unknown>>>
   }) {
     const { node, context } = params
 
@@ -242,8 +242,10 @@ export const ASTUtils = {
 
     return resolvedNode.init
   },
-  getNestedReturnStatements(node: TSESTree.Node): TSESTree.ReturnStatement[] {
-    const returnStatements: TSESTree.ReturnStatement[] = []
+  getNestedReturnStatements(
+    node: TSESTree.Node,
+  ): Array<TSESTree.ReturnStatement> {
+    const returnStatements: Array<TSESTree.ReturnStatement> = []
 
     if (node.type === AST_NODE_TYPES.ReturnStatement) {
       returnStatements.push(node)

packages/eslint-plugin-query/src/utils/detect-react-query-imports.ts

@@ -18,7 +18,7 @@ export type EnhancedCreate = (
 
 export function detectTanstackQueryImports(create: EnhancedCreate): Create {
   return (context, optionsWithDefault) => {
-    const tanstackQueryImportSpecifiers: TSESTree.ImportClause[] = []
+    const tanstackQueryImportSpecifiers: Array<TSESTree.ImportClause> = []
 
     const helpers: Helpers = {
       isTanstackQueryImport(node) {

packages/eslint-plugin-query/src/utils/unique-by.ts

@@ -1,3 +1,3 @@
-export function uniqueBy<T>(arr: T[], fn: (x: T) => unknown): T[] {
+export function uniqueBy<T>(arr: Array<T>, fn: (x: T) => unknown): Array<T> {
   return arr.filter((x, i, a) => a.findIndex((y) => fn(x) === fn(y)) === i)
 }

packages/query-async-storage-persister/src/__tests__/asyncThrottle.test.ts

@@ -5,7 +5,7 @@ import { sleep as delay } from './utils'
 describe('asyncThrottle', () => {
   test('basic', async () => {
     const interval = 10
-    const execTimeStamps: number[] = []
+    const execTimeStamps: Array<number> = []
     const mockFunc = vi.fn(
       async (id: number, complete?: (value?: unknown) => void) => {
         await delay(1)
@@ -33,7 +33,7 @@ describe('asyncThrottle', () => {
 
   test('Bug #3331 case 1: Special timing', async () => {
     const interval = 1000
-    const execTimeStamps: number[] = []
+    const execTimeStamps: Array<number> = []
     const mockFunc = vi.fn(
       async (id: number, complete?: (value?: unknown) => void) => {
         await delay(30)
@@ -62,7 +62,7 @@ describe('asyncThrottle', () => {
 
   test('Bug #3331 case 2: "func" execution time is greater than the interval.', async () => {
     const interval = 1000
-    const execTimeStamps: number[] = []
+    const execTimeStamps: Array<number> = []
     const mockFunc = vi.fn(
       async (id: number, complete?: (value?: unknown) => void) => {
         await delay(interval + 10)

packages/query-async-storage-persister/src/asyncThrottle.ts

@@ -7,7 +7,7 @@ const noop = () => {
   /* do nothing */
 }
 
-export function asyncThrottle<Args extends readonly unknown[]>(
+export function asyncThrottle<Args extends ReadonlyArray<unknown>>(
   func: (...args: Args) => Promise<void>,
   { interval = 1000, onError = noop }: AsyncThrottleOptions = {},
 ) {

packages/query-core/src/hydration.ts

@@ -38,8 +38,8 @@ interface DehydratedQuery {
 }
 
 export interface DehydratedState {
-  mutations: DehydratedMutation[]
-  queries: DehydratedQuery[]
+  mutations: Array<DehydratedMutation>
+  queries: Array<DehydratedQuery>
 }
 
 // FUNCTIONS