Skip to content

Add conj with cost_and_gradient #99

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Add conj with cost_and_gradient #99

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c8a60f3
Add conj with cost_and_gradient
fliingelephant Jul 2, 2025
04b7215
Fix test
fliingelephant Jul 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/belief.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@ function _collect_message!(vectors_out::Vector, t::AbstractArray, vectors_in::Ve
# TODO: speed up if needed!
code = star_code(length(vectors_in))
cost, gradient = cost_and_gradient(code, (t, vectors_in...))
for (o, g) in zip(vectors_out, gradient[2:end])
for (o, g) in zip(vectors_out, conj.(gradient[2:end]))
o .= g
end
return cost[]
Expand Down
1 change: 1 addition & 0 deletions src/mar.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,6 +78,7 @@ probabilities of the queried variables, represented by tensors.
function marginals(tn::TensorNetworkModel; usecuda = false, rescale = true)::Dict{Vector{Int}}
# sometimes, the cost can overflow, then we need to rescale the tensors during contraction.
cost, grads = cost_and_gradient(tn.code, (adapt_tensors(tn; usecuda, rescale)...,))
grads = conj.(grads)
@debug "cost = $cost"
ixs = OMEinsum.getixsv(tn.code)
queryvars = ixs[tn.unity_tensors_idx]
Expand Down
8 changes: 5 additions & 3 deletions test/belief.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ end
@testset "belief propagation" begin
n = 5
chi = 3
mps_uai = TensorInference.random_tensor_train_uai(Float64, n, chi)
mps_uai = TensorInference.random_tensor_train_uai(ComplexF64, n, chi)
Copy link
Member

@GiggleLiu GiggleLiu Jul 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please test both Float64 and ComplexF64.

bp = BeliefPropgation(mps_uai)
@test TensorInference.initial_state(bp) isa TensorInference.BPState
state, info = belief_propagate(bp)
Expand All @@ -63,7 +63,7 @@ end
@testset "belief propagation on circle" begin
n = 10
chi = 3
mps_uai = TensorInference.random_tensor_train_uai(Float64, n, chi; periodic=true)
mps_uai = TensorInference.random_tensor_train_uai(ComplexF64, n, chi; periodic=true) # FIXME: fail to converge
bp = BeliefPropgation(mps_uai)
@test TensorInference.initial_state(bp) isa TensorInference.BPState
state, info = belief_propagate(bp; max_iter=100, tol=1e-6)
Expand All @@ -74,7 +74,9 @@ end
mars = marginals(state)
mars_tnet = marginals(tnet)
for v in 1:TensorInference.num_variables(bp)
@test mars[[v]] ≈ mars_tnet[[v]] atol=1e-4
gauge = mars[[v]] ./ mars_tnet[[v]]
@test all(gauge .≈ gauge[1])
@test mars[[v]] ≈ gauge[1] .* mars_tnet[[v]] atol=1e-4
end
end

Expand Down