From 57b36fe0fb06be17feae5c2968091ec0d54233a8 Mon Sep 17 00:00:00 2001 From: TomJGooding <101601846+TomJGooding@users.noreply.github.com> Date: Fri, 8 Aug 2025 12:35:47 +0100 Subject: [PATCH 1/3] test(footer): check footer key clicked in CI --- tests/footer/test_footer.py | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/tests/footer/test_footer.py b/tests/footer/test_footer.py index 61c41a0879..022725874b 100644 --- a/tests/footer/test_footer.py +++ b/tests/footer/test_footer.py @@ -53,9 +53,13 @@ def action_app_binding(self) -> None: await pilot.pause() assert app_binding_count == 0 await app.wait_for_refresh() - await pilot.click("Footer", offset=(1, 0)) + # await pilot.click("Footer", offset=(1, 0)) + footer_key_clicked = await pilot.click("FooterKey") + assert footer_key_clicked await pilot.pause() assert app_binding_count == 1 - await pilot.click("Footer") + # await pilot.click("Footer") + footer_key_clicked = await pilot.click("FooterKey") + assert footer_key_clicked await pilot.pause() assert app_binding_count == 2 From 0d1009fc9edb78a608059a491570c0405232a566 Mon Sep 17 00:00:00 2001 From: TomJGooding <101601846+TomJGooding@users.noreply.github.com> Date: Fri, 8 Aug 2025 12:58:55 +0100 Subject: [PATCH 2/3] test(footer): increase initial pause in flaky test --- tests/footer/test_footer.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/footer/test_footer.py b/tests/footer/test_footer.py index 022725874b..09d32baddb 100644 --- a/tests/footer/test_footer.py +++ b/tests/footer/test_footer.py @@ -50,7 +50,7 @@ def action_app_binding(self) -> None: app = PriorityBindingApp() async with app.run_test() as pilot: - await pilot.pause() + await pilot.pause(0.4) assert app_binding_count == 0 await app.wait_for_refresh() # await pilot.click("Footer", offset=(1, 0)) From a7d941f510c10074f5af7c51c7bce18744c3f23c Mon Sep 17 00:00:00 2001 From: TomJGooding <101601846+TomJGooding@users.noreply.github.com> Date: Fri, 8 Aug 2025 14:03:13 +0100 Subject: [PATCH 3/3] test(footer): comment the pause and checks --- tests/footer/test_footer.py | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/tests/footer/test_footer.py b/tests/footer/test_footer.py index 09d32baddb..856207129d 100644 --- a/tests/footer/test_footer.py +++ b/tests/footer/test_footer.py @@ -50,16 +50,17 @@ def action_app_binding(self) -> None: app = PriorityBindingApp() async with app.run_test() as pilot: - await pilot.pause(0.4) assert app_binding_count == 0 + # Pause to ensure the footer is fully composed to avoid flakiness in CI + await pilot.pause(0.4) await app.wait_for_refresh() - # await pilot.click("Footer", offset=(1, 0)) + footer_key_clicked = await pilot.click("FooterKey") - assert footer_key_clicked + assert footer_key_clicked is True # Sanity check await pilot.pause() assert app_binding_count == 1 - # await pilot.click("Footer") + footer_key_clicked = await pilot.click("FooterKey") - assert footer_key_clicked + assert footer_key_clicked is True # Sanity check await pilot.pause() assert app_binding_count == 2