feat: allow to disable guard to ignore objects far away from the origin

Author: agviegas

packages/fragments/package.json

@@ -1,7 +1,7 @@
 {
   "name": "@thatopen/fragments",
   "description": "Simple geometric system built on top of Three.js to display 3D BIM data efficiently.",
-  "version": "3.1.5",
+  "version": "3.1.6",
   "author": "That Open Company",
   "contributors": [
     "Antonio Gonzalez Viegas (https://github.com/agviegas)",

packages/fragments/src/Importers/IfcImporter/index.ts

@@ -96,6 +96,15 @@ export class IfcImporter {
    */
   replaceStoreyElevation = true;
 
+  /**
+   * If set, ignores the items that are further away to the origin than this value.
+   * Keep in mind that if your IFC is correctly georreferenced, this value should never
+   * be too high. If it's too high, it's either because your file uses absolute coordinates,
+   * (which is a very bad idea, and usually due to a poor IFC export) or because there are
+   * objects that are very, very far away (very unlikely).
+   */
+  distanceThreshold: number | null = 100000;
+
   private get builder() {
     if (!this._builder) {
       throw new Error("Fragments: Builder not initialized");

packages/fragments/src/Importers/IfcImporter/src/geometry/ifc-file-reader.ts

@@ -91,9 +91,6 @@ export class IfcFileReader {
     WEBIFC.IFCEARTHWORKSCUT,
   ]);
 
-  // TODO: Expose this value?
-  distanceThreshold = 100000; // 100 km
-
   scene: THREE.Scene | null = null;
 
   isolatedMeshes: Set<number> | null = null;
@@ -189,17 +186,20 @@ export class IfcFileReader {
       const { transformWithoutScale } = this.removeScale(transformArray);
 
       // Check that the object is not too far away
-      tempPosition.set(0, 0, 0);
-      tempPosition.applyMatrix4(transformWithoutScale);
-      if (
-        tempPosition.x > this.distanceThreshold ||
-        tempPosition.y > this.distanceThreshold ||
-        tempPosition.z > this.distanceThreshold
-      ) {
-        console.log(
-          `Object ${element.id} is more than ${this.distanceThreshold} meters away from the origin and will be skipped.`,
-        );
-        return;
+      const distanceThreshold = this._serializer.distanceThreshold;
+      if (distanceThreshold !== null) {
+        tempPosition.set(0, 0, 0);
+        tempPosition.applyMatrix4(transformWithoutScale);
+        if (
+          tempPosition.x > distanceThreshold ||
+          tempPosition.y > distanceThreshold ||
+          tempPosition.z > distanceThreshold
+        ) {
+          console.log(
+            `Object ${element.id} is more than ${distanceThreshold} meters away from the origin and will be skipped.`,
+          );
+          return;
+        }
       }
 
       for (let i = 0; i < geometryCount; i++) {

packages/fragments/src/Importers/IfcImporter/src/geometry/index.ts

@@ -23,7 +23,11 @@ export class IfcGeometryProcessor {
     absolute: false,
   };
 
-  constructor(private _serializer: IfcImporter) {}
+  private _serializer: IfcImporter;
+
+  constructor(_serializer: IfcImporter) {
+    this._serializer = _serializer;
+  }
 
   async process(data: GeometriesProcessData) {
     const { builder } = data;

packages/fragments/src/Importers/IfcImporter/test.ts

@@ -32,14 +32,15 @@ const run = async (serialize: boolean) => {
 
     // Read the file
     // const ifcFile = fs.readFileSync(`${name}${extension}`)
-    const url = "/resources/ifc/test/small-civil-q2.ifc";
+    const url = "/resources/ifc/test/125_C3D_BIM_M1_K.ifc";
     const ifcFile = await fetch(url);
     const ifcBuffer = await ifcFile.arrayBuffer();
     const typedArray = new Uint8Array(ifcBuffer);
 
     // Serialize the data
     // const serializationStart = performance.now()
     const serializer = new IfcImporter(); // The serializer can be other than IFC
+    serializer.distanceThreshold = null;
     // serializer.classesToInclude = [{entities: [WEBIFC.IFCWALLSTANDARDCASE, WEBIFC.IFCBUILDINGSTOREY], rels: [WEBIFC.IFCRELCONTAINEDINSPATIALSTRUCTURE]}]
     const raw = false;
     const conversionStart = performance.now();