Correct full_domain=True For from_pandas

* Previously, the `tile_max` was only correctly calculated for
  `np.int64`. This correctly set the `dim_max` to `dtype_max - tile`
  but only for `np.int64`
* All other integer dtypes had `dim_max` set to `dtype_max` which
  resulted in a domain range that was too large
* We also need to account for when the tile extent is larger than
  the range of the full domain. For an instance, when we have a dim
  dtype of `np.int8`, the default tile extent of 10000 will be much
  larger than the range of the full domain

Author: nguyenv

tiledb/dataframe_.py

@@ -249,8 +249,11 @@ def dim_for_column(name, values, dtype, tile, full_domain=False, dim_filters=Non
                 dim_min = dtype_min
 
             if np.issubdtype(dtype, np.integer):
-                tile_max = np.iinfo(np.uint64).max - tile
-                if np.uint64(dtype_max - dtype_min) > tile_max:
+                tile_max = np.iinfo(dtype).max - tile
+
+                if tile_max < 0:
+                    dim_max -= 1
+                elif dtype_max - dtype_min > tile_max:
                     dim_max = dtype_max - tile
         else:
             dim_min, dim_max = None, None
@@ -479,7 +482,7 @@ def _from_pandas(uri, dataframe, tiledb_args):
 
     # TODO: disentangle the full_domain logic
     full_domain = tiledb_args.get("full_domain", False)
-    if sparse == False and (not index_dims or "index_col" not in kwargs):
+    if sparse == False and (not index_dims or "index_col" not in tiledb_args):
         full_domain = True
     if full_domain is None and tiledb_args.get("nrows"):
         full_domain = False

tiledb/tests/test_pandas_dataframe.py

@@ -1,3 +1,4 @@
+from curses import A_ATTRIBUTES
 import pytest
 
 pd = pytest.importorskip("pandas")
@@ -1476,6 +1477,48 @@ def assert_filters_eq(left, right):
                     with tiledb.open(uri) as A:
                         assert_filters_eq(getter(A), f)
 
+    @pytest.mark.parametrize(
+        "dtype",
+        [
+            np.uint8,
+            np.uint16,
+            np.uint32,
+            np.uint64,
+            np.int8,
+            np.int16,
+            np.int32,
+            np.int64,
+        ],
+    )
+    def test_full_domain(self, dtype):
+        uri = self.path("test_full_domain")
+
+        df = pd.DataFrame(
+            {
+                "d": np.random.randint(0, 10, size=10, dtype=dtype),
+                "a": np.random.random(size=10),
+            }
+        )
+
+        tiledb.from_pandas(
+            uri,
+            df,
+            index_dims=["d"],
+            sparse=True,
+            full_domain=True,
+        )
+
+        with tiledb.open(uri, "r") as A:
+            dim = A.dim("d")
+            iinfo = np.iinfo(dtype)
+            assert dim.domain[0] == iinfo.min
+            if dtype in (np.uint8, np.int8):
+                assert A.dim("d").tile == 254
+                assert dim.domain[1] == iinfo.max - 1
+            else:
+                assert A.dim("d").tile == 10000
+                assert dim.domain[1] == iinfo.max - A.dim("d").tile
+
 
 ###############################################################################