Fix TW0003 analyzer to properly handle editorconfig exclusions

- Changed from GlobalOptions to file-specific options for reading excluded_files
- Merge configured exclusions with default exclusions instead of replacing
- Added more default exclusions for generated files (*.GlobalUsings.g.cs, *.AssemblyAttributes.cs)
- Fixed code style warnings (explicit types, simplified namespace)
- Test project .editorconfig now only needs to specify additional exclusions

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <[email protected]>

Author: StevenTCramer

source/timewarp-source-generators/file-name-rule-analyzer.cs

@@ -30,26 +30,29 @@ public class FileNameRuleAnalyzer : IIncrementalGenerator
     "Directory.Build.props",
     "Directory.Build.targets",
     "Directory.Packages.props",
-    "AssemblyInfo.cs",
+    "*AssemblyInfo.cs",
+    "*.AssemblyInfo.cs",
+    "*.AssemblyAttributes.cs",
+    "*.GlobalUsings.g.cs",
     "AnalyzerReleases.Shipped.md",
     "AnalyzerReleases.Unshipped.md"
   ];
 
   public void Initialize(IncrementalGeneratorInitializationContext context)
   {
     // Create a value provider that provides all syntax trees with config options
-    var syntaxTreesWithConfig = context.CompilationProvider
+    IncrementalValuesProvider<(SyntaxTree tree, AnalyzerConfigOptionsProvider configOptions)> syntaxTreesWithConfig = context.CompilationProvider
       .Combine(context.AnalyzerConfigOptionsProvider)
       .SelectMany((source, _) =>
       {
-        var (compilation, configOptions) = source;
+        (Compilation compilation, AnalyzerConfigOptionsProvider configOptions) = source;
         return compilation.SyntaxTrees.Select(tree => (tree, configOptions));
       });
 
     // Register diagnostics for each syntax tree
     context.RegisterSourceOutput(syntaxTreesWithConfig, (spc, source) =>
     {
-      var (tree, configOptions) = source;
+      (SyntaxTree tree, AnalyzerConfigOptionsProvider configOptions) = source;
       AnalyzeFileNaming(spc, tree, configOptions);
     });
   }
@@ -69,7 +72,7 @@ private void AnalyzeFileNaming(SourceProductionContext context, SyntaxTree tree,
       return;
 
     // Get configured exceptions
-    string[] exceptions = GetConfiguredExceptions(configOptions);
+    string[] exceptions = GetConfiguredExceptions(configOptions, tree);
 
     // Check if file matches any exception pattern
     if (IsFileExcepted(fileName, exceptions))
@@ -78,28 +81,33 @@ private void AnalyzeFileNaming(SourceProductionContext context, SyntaxTree tree,
     // Check if file name follows kebab-case pattern
     if (!KebabCasePattern.IsMatch(fileName))
     {
-      Location location = Location.Create(
+      var location = Location.Create(
         tree,
-        Microsoft.CodeAnalysis.Text.TextSpan.FromBounds(0, 0)
+        TextSpan.FromBounds(0, 0)
       );
 
-      Diagnostic diagnostic = Diagnostic.Create(Rule, location, fileName);
+      var diagnostic = Diagnostic.Create(Rule, location, fileName);
       context.ReportDiagnostic(diagnostic);
     }
   }
 
-  private string[] GetConfiguredExceptions(AnalyzerConfigOptionsProvider configOptions)
+  private string[] GetConfiguredExceptions(AnalyzerConfigOptionsProvider configOptions, SyntaxTree tree)
   {
+    // Get file-specific options
+    AnalyzerConfigOptions options = configOptions.GetOptions(tree);
+    
     // Try to get configured exceptions from .editorconfig
-    if (configOptions.GlobalOptions.TryGetValue(
+    if (options.TryGetValue(
       "dotnet_diagnostic.TW0003.excluded_files", 
       out string? configuredExceptions) && !string.IsNullOrEmpty(configuredExceptions))
     {
       // Split by semicolon and trim whitespace
-      return configuredExceptions
-        .Split(new[] { ';' }, StringSplitOptions.RemoveEmptyEntries)
-        .Select(s => s.Trim())
-        .ToArray();
+      IEnumerable<string> additionalExceptions = configuredExceptions
+        .Split([';'], StringSplitOptions.RemoveEmptyEntries)
+        .Select(s => s.Trim());
+      
+      // Merge defaults with configured exceptions
+      return [.. DefaultExceptions, .. additionalExceptions];
     }
 
     // Return default exceptions if not configured

tests/timewarp-source-generators-test-console/.editorconfig

@@ -5,6 +5,6 @@ root = true
 [*.cs]
 
 dotnet_diagnostic.TW0003.severity = error  # Set to warning/error to enforce kebab-case file naming
-# dotnet_diagnostic.TW0003.excluded_files = 
+dotnet_diagnostic.TW0003.excluded_files = PascalCaseTest.cs 
 # Enable TW0004 - XML documentation to markdown analyzer
 dotnet_diagnostic.TW0004.severity = suggestion