Defer list value stringification until render

This removes an unnecessary array copy from monitor adapter

Author: GarboMuffin

src/components/monitor/list-monitor-scroller.jsx

@@ -6,6 +6,7 @@ import {FormattedMessage} from 'react-intl';
 
 import styles from './monitor.css';
 import {List} from 'react-virtualized';
+import {safeStringify} from '../../lib/tw-safe-stringify.js';
 
 class ListMonitorScroller extends React.Component {
     constructor (props) {
@@ -71,7 +72,9 @@ class ListMonitorScroller extends React.Component {
                         </div>
 
                     ) : (
-                        <div className={styles.valueInner}>{this.props.values[index]}</div>
+                        <div className={styles.valueInner}>
+                            {safeStringify(this.props.values[index])}
+                        </div>
                     )}
                 </div>
             </div>

src/containers/list-monitor.jsx

@@ -7,6 +7,7 @@ import {getEventXY} from '../lib/touch-utils';
 import {getVariableValue, setVariableValue} from '../lib/variable-utils';
 import ListMonitorComponent from '../components/monitor/list-monitor.jsx';
 import {Map} from 'immutable';
+import {safeStringify} from '../lib/tw-safe-stringify.js';
 
 class ListMonitor extends React.Component {
     constructor (props) {
@@ -38,7 +39,7 @@ class ListMonitor extends React.Component {
 
         this.setState({
             activeIndex: index,
-            activeValue: this.props.value[index]
+            activeValue: safeStringify(this.props.value[index])
         });
     }
 

src/lib/monitor-adapter.js

@@ -34,15 +34,8 @@ export default function ({id, spriteName, opcode, params, value, vm}) {
     }
 
     // Anything that isn't a string or number, such as a boolean or object, should be converted to string.
-    if (Array.isArray(value)) {
-        value = value.slice();
-        for (let i = 0; i < value.length; i++) {
-            const item = value[i];
-            if (typeof item !== 'string' || typeof item !== 'number') {
-                value[i] = safeStringify(item);
-            }
-        }
-    } else if (typeof value !== 'string' || typeof value !== 'number') {
+    // For lists, we do this when we display the list row instead of doing a full list copy on every change.
+    if (!Array.isArray(value) && (typeof value !== 'string' || typeof value !== 'number')) {
         value = safeStringify(value);
     }