Skip to content

v0.38 #1018

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 20 commits into
base: main
Choose a base branch
from
Open

v0.38 #1018

wants to merge 20 commits into from
+1,810 −2,167

Conversation

penelopeysm
Copy link
Member

@penelopeysm penelopeysm commented Aug 8, 2025 •
edited by mhauru
Loading

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 8, 2025 •
edited
Loading

Benchmark Report for Commit 0114e64

Computer Information

Julia Version 1.11.7
Commit f2b3dbda30a (2025-09-08 12:10 UTC)
Build Info:
  Official https://julialang.org/ release
Platform Info:
  OS: Linux (x86_64-linux-gnu)
  CPU: 4 × AMD EPYC 7763 64-Core Processor
  WORD_SIZE: 64
  LLVM: libLLVM-16.0.6 (ORCJIT, znver3)
Threads: 1 default, 0 interactive, 1 GC (on 4 virtual cores)

Benchmark Results

┌───────────────────────┬───────┬─────────────┬───────────────────┬────────┬────────────────┬─────────────────┐
│                 Model │   Dim │  AD Backend │           VarInfo │ Linked │ t(eval)/t(ref) │ t(grad)/t(eval) │
├───────────────────────┼───────┼─────────────┼───────────────────┼────────┼────────────────┼─────────────────┤
│ Simple assume observe │     1 │ forwarddiff │             typed │  false │            8.5 │             1.6 │
│           Smorgasbord │   201 │ forwarddiff │             typed │  false │          635.2 │            43.6 │
│           Smorgasbord │   201 │ forwarddiff │ simple_namedtuple │   true │          411.8 │            52.7 │
│           Smorgasbord │   201 │ forwarddiff │           untyped │   true │         1163.6 │            29.7 │
│           Smorgasbord │   201 │ forwarddiff │       simple_dict │   true │         6444.2 │            28.6 │
│           Smorgasbord │   201 │ reversediff │             typed │   true │         1022.9 │            40.9 │
│           Smorgasbord │   201 │    mooncake │             typed │   true │          980.1 │             4.5 │
│    Loop univariate 1k │  1000 │    mooncake │             typed │   true │         5750.3 │             4.3 │
│       Multivariate 1k │  1000 │    mooncake │             typed │   true │          964.6 │             9.1 │
│   Loop univariate 10k │ 10000 │    mooncake │             typed │   true │        64679.1 │             3.9 │
│      Multivariate 10k │ 10000 │    mooncake │             typed │   true │         8179.8 │            10.3 │
│               Dynamic │    10 │    mooncake │             typed │   true │          129.7 │            11.3 │
│              Submodel │     1 │    mooncake │             typed │   true │           12.2 │             5.1 │
│                   LDA │    12 │ reversediff │             typed │   true │         1006.2 │             2.0 │
└───────────────────────┴───────┴─────────────┴───────────────────┴────────┴────────────────┴─────────────────┘

@codecov Codecov
Copy link

codecov bot commented Aug 8, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 81.33971% with 78 lines in your changes missing coverage. Please review.
✅ Project coverage is 82.39%. Comparing base (3ff4149) to head (08212a2).

Files with missing lines Patch % Lines
src/contexts/conditionfix.jl 70.44% 47 Missing ⚠️
src/simple_varinfo.jl 40.00% 6 Missing ⚠️
src/test_utils/contexts.jl 83.33% 5 Missing ⚠️
src/varinfo.jl 81.81% 4 Missing ⚠️
src/contexts/prefix.jl 91.17% 3 Missing ⚠️
src/model.jl 78.57% 3 Missing ⚠️
src/sampler.jl 77.77% 2 Missing ⚠️
src/submodel.jl 50.00% 2 Missing ⚠️
src/threadsafe.jl 50.00% 2 Missing ⚠️
src/contexts/init.jl 98.07% 1 Missing ⚠️
... and 3 more
Additional details and impacted files 
@@           Coverage Diff            @@
##             main    #1018    +/-   ##
========================================
  Coverage   82.39%   82.39%            
========================================
  Files          39       42     +3     
  Lines        3965     3818   -147     
========================================
- Hits         3267     3146   -121     
+ Misses        698      672    -26

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 16862187845

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-2.6%) to 79.99%
Totals Coverage Status
Change from base Build 16862061135: -2.6%
Covered Lines: 3142
Relevant Lines: 3928
💛 - Coveralls

@coveralls
Copy link

coveralls commented Aug 10, 2025 •
edited
Loading

Pull Request Test Coverage Report for Build 16862187845

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.5%) to 82.075%
Totals Coverage Status
Change from base Build 16862061135: -0.5%
Covered Lines: 3228
Relevant Lines: 3933
💛 - Coveralls

@coveralls
Copy link

coveralls commented Aug 10, 2025 •
edited
Loading

Pull Request Test Coverage Report for Build 17881302441

Details

  • 127 of 161 (78.88%) changed or added relevant lines in 13 files are covered.
  • 112 unchanged lines in 19 files lost coverage.
  • Overall coverage decreased (-1.1%) to 81.452%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/model_utils.jl 1 2 50.0%
src/sampler.jl 7 8 87.5%
src/test_utils/model_interface.jl 0 1 0.0%
src/test_utils/sampler.jl 0 1 0.0%
src/contexts/init.jl 49 52 94.23%
src/model.jl 10 13 76.92%
src/test_utils/contexts.jl 25 30 83.33%
src/simple_varinfo.jl 4 10 40.0%
ext/DynamicPPLJETExt.jl 0 13 0.0%
Files with Coverage Reduction New Missed Lines %
ext/DynamicPPLEnzymeCoreExt.jl 1 0.0%
ext/DynamicPPLForwardDiffExt.jl 1 63.64%
src/debug_utils.jl 1 90.24%
src/extract_priors.jl 1 65.79%
src/model.jl 1 83.93%
src/values_as_in_model.jl 1 82.76%
ext/DynamicPPLJETExt.jl 2 0.0%
src/abstract_varinfo.jl 2 74.86%
src/logdensityfunction.jl 2 53.57%
src/sampler.jl 2 77.78%
Totals Coverage Status
Change from base Build 17881298165: -1.1%
Covered Lines: 3175
Relevant Lines: 3898
💛 - Coveralls

@github-actions GitHub Actions
Copy link
Contributor

DynamicPPL.jl documentation for PR #1018 is available at:
https://TuringLang.github.io/DynamicPPL.jl/previews/PR1018/

penelopeysm and others added 15 commits August 13, 2025 17:47
@penelopeysm @mhauru
InitContext, part 3 - Introduce InitContext (#981)
991e825 
* Implement InitContext

* Fix loading order of modules; move `prefix(::Model)` to model.jl

* Add tests for InitContext behaviour

* inline `rand(::Distributions.Uniform)`

Note that, apart from being simpler code, Distributions.Uniform also
doesn't allow the lower and upper bounds to be exactly equal (but we
might like to keep that option open in DynamicPPL, e.g. if the user
wants to initialise all values to the same value in linked space).

* Document

* Add a test to check that `init!!` doesn't change linking

* Fix `push!` for VarNamedVector

This should have been changed in #940, but slipped through as the file
wasn't listed as one of the changed files.

* Add some line breaks

Co-authored-by: Markus Hauru <[email protected]>

* Add the option of no fallback for ParamsInit

* Improve docstrings

* typo

* `p.default` -> `p.fallback`

* Rename `{Prior,Uniform,Params}Init` -> `InitFrom{Prior,Uniform,Params}`

---------

Co-authored-by: Markus Hauru <[email protected]>
@penelopeysm
Merge branch 'main' into breaking
2d18ce3
@penelopeysm
use varname_leaves from AbstractPPL instead (#1030)
c8e5841 
* use `varname_leaves` from AbstractPPL instead

* add changelog entry

* fix import
@penelopeysm
tidy occurrences of varname_leaves as well (#1031)
fead2a2
@penelopeysm
Merge branch 'main' into breaking
1e1cd94
@penelopeysm @mhauru
InitContext, part 4 - Use init!! to replace `evaluate_and_sample!…
729bfba 
…!`, `predict`, `returned`, and `initialize_values` (#984)

* Replace `evaluate_and_sample!!` -> `init!!`

* Use `ParamsInit` for `predict`; remove `setval_and_resample!` and friends

* Use `init!!` for initialisation

* Paper over the `Sampling->Init` context stack (pending removal of SamplingContext)

* Remove SamplingContext from JETExt to avoid triggering `Sampling->Init` pathway

* Remove `predict` on vector of VarInfo

* Fix some tests

* Remove duplicated test

* Simplify context testing

* Rename FooInit -> InitFromFoo

* Fix JETExt

* Fix JETExt properly

* Fix tests

* Improve comments

* Remove duplicated tests

* Docstring improvements

Co-authored-by: Markus Hauru <[email protected]>

* Concretise `chain_sample_to_varname_dict` using chain value type

* Clarify testset name

* Re-add comment that shouldn't have vanished

* Fix stale Requires dep

* Fix default_varinfo/initialisation for odd models

* Add comment to src/sampler.jl

Co-authored-by: Markus Hauru <[email protected]>

---------

Co-authored-by: Markus Hauru <[email protected]>
@penelopeysm
Merge branch 'main' into breaking
2ca382e
@penelopeysm
Merge branch 'main' into breaking
6d43231
@penelopeysm
Merge branch 'main' into breaking
0114e64
@penelopeysm @mhauru
InitContext, part 5 - Remove SamplingContext, `SampleFrom{Prior,U…
d3d32e4 
…niform}`, `{tilde_,}assume` (#985)

* Remove `SamplingContext` for good

* Remove `tilde_assume` as well

* Split up tilde_observe!! for Distribution / Submodel

* Tidy up tilde-pipeline methods and docstrings

* Fix tests

* fix ambiguity

* Add changelog

* Update HISTORY.md

Co-authored-by: Markus Hauru <[email protected]>

---------

Co-authored-by: Markus Hauru <[email protected]>
@penelopeysm
fix missing import
5a98037
@penelopeysm
Shuffle context code around and remove dead code (#1050)
7311465
@mhauru
Delete the "del" flag (#1058)
c08cfa5 
* Delete del

* Fix a typo

* Add HISTORY entry about del
@penelopeysm
Merge branch 'main' into breaking
11d0b69
@penelopeysm
Fixes for Turing 0.41 (#1057)
08212a2 
* setleafcontext(model, ctx) and various other fixes

* fix a bug

* Add warning for `initial_parameters=...`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@penelopeysm penelopeysm

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@penelopeysm @coveralls @mhauru