-
Notifications
You must be signed in to change notification settings - Fork 229
Temporarily change tests to use 1.11 #2685
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Turing.jl documentation for PR #2685 is available at: |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2685 +/- ##
=======================================
Coverage 87.21% 87.21%
=======================================
Files 22 22
Lines 1431 1431
=======================================
Hits 1248 1248
Misses 183 183 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't have major issue. But since we know that 1.12 is going to fail, should we just skip it altogether for now? (I am also not sure why some CIs seem to stuck.)
|
Fair point, done. I also comment out |
|
CI is failing due to this: SciML/Optimization.jl#1056 Since this isn't in a rush, and I expect that to be fixed within 24h, let's just wait until tomorrow. I may be on annual leave, but if someone else wants to retrigger CI once the above issue is closed and merge if it passes, feel free. |
I think it's because the '1' test is set as a 'required' test, somewhere in the repository settings. Thus GitHub's UI puts a dummy entry for that because it expects that test to be run. (It could certainly be more intuitive) |
Will open an issue to track the fact that this should be reverted ASAP once Mooncake and Libtask are back online.