Skip to content

Conversation

mhauru
Copy link
Member

@mhauru mhauru commented Oct 13, 2025

Will open an issue to track the fact that this should be reverted ASAP once Mooncake and Libtask are back online.

@github-actions
Copy link
Contributor

Turing.jl documentation for PR #2685 is available at:
https://TuringLang.github.io/Turing.jl/previews/PR2685/

@codecov
Copy link

codecov bot commented Oct 13, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 87.21%. Comparing base (d8fbe78) to head (46491d9).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2685   +/-   ##
=======================================
  Coverage   87.21%   87.21%           
=======================================
  Files          22       22           
  Lines        1431     1431           
=======================================
  Hits         1248     1248           
  Misses        183      183           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@sunxd3 sunxd3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have major issue. But since we know that 1.12 is going to fail, should we just skip it altogether for now? (I am also not sure why some CIs seem to stuck.)

@mhauru
Copy link
Member Author

mhauru commented Oct 14, 2025

Fair point, done. I also comment out 'pre' since it's currently the same as '1', i.e. 1.12.0.

@mhauru mhauru requested a review from sunxd3 October 14, 2025 13:52
@mhauru
Copy link
Member Author

mhauru commented Oct 14, 2025

CI is failing due to this: SciML/Optimization.jl#1056

Since this isn't in a rush, and I expect that to be fixed within 24h, let's just wait until tomorrow. I may be on annual leave, but if someone else wants to retrigger CI once the above issue is closed and merge if it passes, feel free.

@penelopeysm penelopeysm reopened this Oct 16, 2025
@penelopeysm
Copy link
Member

penelopeysm commented Oct 16, 2025

I am also not sure why some CIs seem to stuck.

I think it's because the '1' test is set as a 'required' test, somewhere in the repository settings. Thus GitHub's UI puts a dummy entry for that because it expects that test to be run.

(It could certainly be more intuitive)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants