-
-
Notifications
You must be signed in to change notification settings - Fork 203
Lifecycle adjustments #939
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Conversation
- Remove monacp-editor-wrapper. Create EditorApp in client - Move languageclient management from wrapper to client - move all tests from wrapper to client - client: proper separation of sub-exports, rename tools to common - monaco-vscode-api independent config and init - clean up and restructure src and test - Update vitest and other dependencies - Update examples - Unify json, eclipse.jdt and groovy example - react component: fix re-render and global init - expand react tests - LanguageClient handling with react component
@CGNonofr I know this is a beast. The wrapper is gone. Everything apart from the react component is back in I have spent some effort to re-write unit tests for the react component. The life cycle issues should be gone and the tests prove that (at least that's my current hope 🙂) |
beast is probably an understatement ^^ I don't think I will be able to add any value reviewing this :-\ except maybe typos? |
What about playing around with /checking the examples and focusing on the usability of the API and the meaningfulness of the tests. |
Is it urgent? I probably won't have the time today, and tomorrow is off |
No urgency, I would like to have your feedback / opinion. I will release next versions. This anyway goes back to the dev branch and not yet to main. |
We can release maintenance builds from main. This is the future, but it won't be ready before August. Time restrictions / vacaction on my end as well. |
Next releases are available. The api changed substantially. moanco-editor-wrapper is gone, but oveall fuctionality is still there. Check the examples and tests before proceeding. This is for evaluation purpose and not intended for production: |
Fixes #919