Skip to content

Lifecycle adjustments #939

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

Lifecycle adjustments #939

wants to merge 1 commit into from

Conversation

kaisalmen
Copy link
Collaborator

@kaisalmen kaisalmen commented Jul 3, 2025

  • Remove monacp-editor-wrapper. Create EditorApp in client
    • Move languageclient management from wrapper to client
    • move all tests from wrapper to client
    • client: proper separation of sub-exports, rename tools to common
  • monaco-vscode-api independent config and init
    • clean up and restructure src and test
    • Update vitest and other dependencies
  • Update examples
    • Unify json, eclipse.jdt and groovy example
  • react component: fix re-render and global init
    • expand react tests
    • LanguageClient handling with react component

Fixes #919

- Remove monacp-editor-wrapper. Create EditorApp in client
  - Move languageclient management from wrapper to client
  - move all tests from wrapper to client
  - client: proper separation of sub-exports, rename tools to common
- monaco-vscode-api independent config and init
  - clean up and restructure src and test
  - Update vitest and other dependencies
- Update examples
  - Unify json, eclipse.jdt and groovy example
- react component: fix re-render and global init
  - expand react tests
  - LanguageClient handling with react component
@kaisalmen kaisalmen marked this pull request as ready for review July 3, 2025 12:37
@kaisalmen
Copy link
Collaborator Author

@CGNonofr I know this is a beast. The wrapper is gone. Everything apart from the react component is back in monaco-languageclient with multiple sub-exports handling the logical structure. monaco-vscode-api handling is clearer now, I think.

I have spent some effort to re-write unit tests for the react component. The life cycle issues should be gone and the tests prove that (at least that's my current hope 🙂)

@kaisalmen kaisalmen requested a review from CGNonofr as a code owner July 3, 2025 12:37
@kaisalmen kaisalmen changed the title WIP: Lifecycle adjustments Lifecycle adjustments Jul 3, 2025
@kaisalmen kaisalmen requested a review from montymxb July 3, 2025 12:38
@CGNonofr
Copy link
Collaborator

CGNonofr commented Jul 3, 2025

beast is probably an understatement ^^

I don't think I will be able to add any value reviewing this :-\ except maybe typos?

@kaisalmen
Copy link
Collaborator Author

kaisalmen commented Jul 3, 2025

I don't think I will be able to add any value reviewing this :-\ except maybe typos?

What about playing around with /checking the examples and focusing on the usability of the API and the meaningfulness of the tests.

@CGNonofr
Copy link
Collaborator

CGNonofr commented Jul 3, 2025

I don't think I will be able to add any value reviewing this :-\ except maybe typos?

What about playing around with /checking the examples and focusing on the usability of the API and the meaningfulness of the tests.

Is it urgent? I probably won't have the time today, and tomorrow is off

@kaisalmen
Copy link
Collaborator Author

No urgency, I would like to have your feedback / opinion. I will release next versions. This anyway goes back to the dev branch and not yet to main.

@kaisalmen
Copy link
Collaborator Author

We can release maintenance builds from main. This is the future, but it won't be ready before August. Time restrictions / vacaction on my end as well.

@kaisalmen
Copy link
Collaborator Author

Next releases are available. The api changed substantially. moanco-editor-wrapper is gone, but oveall fuctionality is still there. Check the examples and tests before proceeding. This is for evaluation purpose and not intended for production:
https://www.npmjs.com/package/monaco-languageclient/v/10.0.0-next.0
https://www.npmjs.com/package/@typefox/monaco-editor-react/v/7.0.0-next.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants