feat: upgrade to NGO v1.8.1, conversion to universal Rpcs, utility assembly includes Unity.Collections [MTT-8188] (#883)

* upgrade to NGO v1.8.1, conversion to universal Rpcs, utility assembly includes Unity.Collections

* fix for connected clients receiving new shutdown message from host

* Utilities package also upgraded to NGO v1.8.1

* changelog additions

* readme badge with NGO upgrade updated

* added Server/Client prefixes for previous Rpc methods

* update to Utilities changelog

* using RpcTargetUse Temp since clientId may change frequently

Author: fernando-cortez

Assets/Scripts/ConnectionManagement/ConnectionState/ClientConnectedState.cs

@@ -1,4 +1,3 @@
-using System;
 using Unity.BossRoom.UnityServices.Lobbies;
 using UnityEngine;
 using VContainer;
@@ -27,7 +26,8 @@ public override void Exit() { }
         public override void OnClientDisconnect(ulong _)
         {
             var disconnectReason = m_ConnectionManager.NetworkManager.DisconnectReason;
-            if (string.IsNullOrEmpty(disconnectReason))
+            if (string.IsNullOrEmpty(disconnectReason) ||
+                disconnectReason == "Disconnected due to host shutting down.")
             {
                 m_ConnectStatusPublisher.Publish(ConnectStatus.Reconnecting);
                 m_ConnectionManager.ChangeState(m_ConnectionManager.m_ClientReconnecting);

Assets/Scripts/Gameplay/Action/ConcreteActions/AOEAction.cs

@@ -35,7 +35,7 @@ public override bool OnStart(ServerCharacter serverCharacter)
             // This means we are responsible for triggering reaction-anims ourselves, which we do in PerformAoe()
             Data.TargetIds = new ulong[0];
             serverCharacter.serverAnimationHandler.NetworkAnimator.SetTrigger(Config.Anim);
-            serverCharacter.clientCharacter.RecvDoActionClientRPC(Data);
+            serverCharacter.clientCharacter.ClientPlayActionRpc(Data);
             return ActionConclusion.Continue;
         }
 

Assets/Scripts/Gameplay/Action/ConcreteActions/ChargedLaunchProjectileAction.cs

@@ -53,7 +53,7 @@ public override bool OnStart(ServerCharacter serverCharacter)
             serverCharacter.serverAnimationHandler.NetworkAnimator.SetTrigger(Config.Anim);
 
             // start the "charging up" ActionFX
-            serverCharacter.clientCharacter.RecvDoActionClientRPC(Data);
+            serverCharacter.clientCharacter.ClientPlayActionRpc(Data);
 
             // sanity-check our data a bit
             Debug.Assert(Config.Projectiles.Length > 1, $"Action {name} has {Config.Projectiles.Length} Projectiles. Expected at least 2!");
@@ -122,7 +122,7 @@ private void StopChargingUp(ServerCharacter parent)
                     parent.serverAnimationHandler.NetworkAnimator.SetTrigger(Config.Anim2);
                 }
 
-                parent.clientCharacter.RecvStopChargingUpClientRpc(GetPercentChargedUp());
+                parent.clientCharacter.ClientStopChargingUpRpc(GetPercentChargedUp());
                 if (!m_HitByAttack)
                 {
                     LaunchProjectile(parent);

Assets/Scripts/Gameplay/Action/ConcreteActions/ChargedShieldAction.cs

@@ -52,7 +52,7 @@ public override bool OnStart(ServerCharacter serverCharacter)
             // raise the start trigger to start the animation loop!
             serverCharacter.serverAnimationHandler.NetworkAnimator.SetTrigger(Config.Anim);
 
-            serverCharacter.clientCharacter.RecvDoActionClientRPC(Data);
+            serverCharacter.clientCharacter.ClientPlayActionRpc(Data);
             return true;
         }
 
@@ -145,7 +145,7 @@ private void StopChargingUp(ServerCharacter parent)
             if (IsChargingUp())
             {
                 m_StoppedChargingUpTime = Time.time;
-                parent.clientCharacter.RecvStopChargingUpClientRpc(GetPercentChargedUp());
+                parent.clientCharacter.ClientStopChargingUpRpc(GetPercentChargedUp());
 
                 parent.serverAnimationHandler.NetworkAnimator.SetTrigger(Config.Anim2);
 

Assets/Scripts/Gameplay/Action/ConcreteActions/DashAttackAction.cs

@@ -38,7 +38,7 @@ public override bool OnStart(ServerCharacter serverCharacter)
             serverCharacter.serverAnimationHandler.NetworkAnimator.SetTrigger(Config.Anim);
 
             // tell clients to visualize this action
-            serverCharacter.clientCharacter.RecvDoActionClientRPC(Data);
+            serverCharacter.clientCharacter.ClientPlayActionRpc(Data);
 
             return ActionConclusion.Continue;
         }
@@ -80,7 +80,7 @@ public override void Cancel(ServerCharacter serverCharacter)
 
             // because the client-side visualization of the action moves the character visualization around,
             // we need to explicitly end the client-side visuals when we abort
-            serverCharacter.clientCharacter.RecvCancelActionsByPrototypeIDClientRpc(ActionID);
+            serverCharacter.clientCharacter.ClientCancelActionsByPrototypeIDRpc(ActionID);
 
         }
 

Assets/Scripts/Gameplay/Action/ConcreteActions/FXProjectileTargetedAction.cs

@@ -49,7 +49,7 @@ public override bool OnStart(ServerCharacter serverCharacter)
 
             serverCharacter.serverAnimationHandler.NetworkAnimator.SetTrigger(Config.Anim);
             // tell clients to visualize this action
-            serverCharacter.clientCharacter.RecvDoActionClientRPC(Data);
+            serverCharacter.clientCharacter.ClientPlayActionRpc(Data);
             return true;
         }
 
@@ -84,7 +84,7 @@ public override void Cancel(ServerCharacter serverCharacter)
         {
             if (!m_ImpactedTarget)
             {
-                serverCharacter.clientCharacter.RecvCancelActionsByPrototypeIDClientRpc(ActionID);
+                serverCharacter.clientCharacter.ClientCancelActionsByPrototypeIDRpc(ActionID);
             }
         }
 

Assets/Scripts/Gameplay/Action/ConcreteActions/LaunchProjectileAction.cs

@@ -21,7 +21,7 @@ public override bool OnStart(ServerCharacter serverCharacter)
             serverCharacter.physicsWrapper.Transform.forward = Data.Direction;
 
             serverCharacter.serverAnimationHandler.NetworkAnimator.SetTrigger(Config.Anim);
-            serverCharacter.clientCharacter.RecvDoActionClientRPC(Data);
+            serverCharacter.clientCharacter.ClientPlayActionRpc(Data);
             return true;
         }
 

Assets/Scripts/Gameplay/Action/ConcreteActions/MeleeAction.cs

@@ -51,7 +51,7 @@ public override bool OnStart(ServerCharacter serverCharacter)
             }
 
             serverCharacter.serverAnimationHandler.NetworkAnimator.SetTrigger(Config.Anim);
-            serverCharacter.clientCharacter.RecvDoActionClientRPC(Data);
+            serverCharacter.clientCharacter.ClientPlayActionRpc(Data);
             return true;
         }
 

Assets/Scripts/Gameplay/Action/ConcreteActions/StealthModeAction.cs

@@ -28,7 +28,7 @@ public override bool OnStart(ServerCharacter serverCharacter)
         {
             serverCharacter.serverAnimationHandler.NetworkAnimator.SetTrigger(Config.Anim);
 
-            serverCharacter.clientCharacter.RecvDoActionClientRPC(Data);
+            serverCharacter.clientCharacter.ClientPlayActionRpc(Data);
 
             return true;
         }
@@ -90,7 +90,7 @@ private void EndStealth(ServerCharacter parent)
                 // presses the Stealth button twice in a row: "end this Stealth action and start a new one". If we cancelled
                 // all actions of this type in Cancel(), we'd end up cancelling both the old AND the new one, because
                 // the new one would already be in the clients' actionFX queue.
-                parent.clientCharacter.RecvCancelActionsByPrototypeIDClientRpc(ActionID);
+                parent.clientCharacter.ClientCancelActionsByPrototypeIDRpc(ActionID);
             }
         }
 

Assets/Scripts/Gameplay/Action/ConcreteActions/TossAction.cs

@@ -40,7 +40,7 @@ public override bool OnStart(ServerCharacter serverCharacter)
             }
 
             serverCharacter.serverAnimationHandler.NetworkAnimator.SetTrigger(Config.Anim);
-            serverCharacter.clientCharacter.RecvDoActionClientRPC(Data);
+            serverCharacter.clientCharacter.ClientPlayActionRpc(Data);
             return true;
         }