Skip to content

Commit a24f801

Browse files
committed
update exception handling
1 parent 6ca274a commit a24f801

File tree

7 files changed

+97
-27
lines changed

7 files changed

+97
-27
lines changed

pom.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@
1010

1111
<modelVersion>4.0.0</modelVersion>
1212
<artifactId>websocket-client</artifactId>
13-
<version>1.0.3</version>
13+
<version>1.0.5</version>
1414
<name>WebsocketClient</name>
1515
<packaging>jar</packaging>
1616

src/main/java/info/unterrainer/websocketclient/SendingMessageWebsocketException.java

Lines changed: 0 additions & 23 deletions
This file was deleted.

src/main/java/info/unterrainer/websocketclient/WebsocketConnection.java

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,9 @@
1111

1212
import info.unterrainer.oauthtokenmanager.LocalOauthTokens;
1313
import info.unterrainer.oauthtokenmanager.OauthTokenManager;
14+
import info.unterrainer.websocketclient.exceptions.WebsocketClosingException;
15+
import info.unterrainer.websocketclient.exceptions.WebsocketConnectingException;
16+
import info.unterrainer.websocketclient.exceptions.WebsocketSendingMessageException;
1417
import jakarta.websocket.ClientEndpointConfig;
1518
import jakarta.websocket.ClientEndpointConfig.Builder;
1619
import jakarta.websocket.CloseReason;
@@ -57,7 +60,7 @@ public void send(String message) {
5760
s.getBasicRemote().sendText(message);
5861
} catch (Exception e) {
5962
log.error("Error sending message: ", e);
60-
throw new SendingMessageWebsocketException(String.format("Failed to send message [%s].", message), e);
63+
throw new WebsocketSendingMessageException(String.format("Failed to send message [%s].", message), e);
6164
}
6265
log.debug("Sent message: " + message);
6366
}
@@ -69,6 +72,7 @@ public void close() {
6972
s.close(new CloseReason(CloseReason.CloseCodes.NORMAL_CLOSURE, "Normal closure"));
7073
} catch (IOException e) {
7174
log.error("Error closing session.", e);
75+
throw new WebsocketClosingException("Failed to close WebSocket session.", e);
7276
}
7377
}
7478

@@ -82,7 +86,7 @@ public void establish() {
8286
log.info("ClientManager created");
8387
} catch (Exception e) {
8488
log.error("Failed to create ClientManager: {}", e.getMessage(), e);
85-
return;
89+
throw new WebsocketConnectingException("Failed to create WebSocket ClientManager.", e);
8690
}
8791
endpoints = new WebsocketEndpoints(this);
8892
Builder c = ClientEndpointConfig.Builder.create();
@@ -107,7 +111,7 @@ public void beforeRequest(Map<String, List<String>> headers) {
107111
container.connectToServer(endpoints, config, URI.create(host));
108112
} catch (Exception e) {
109113
log.error("Error connecting to WebSocket server: ", e);
110-
return;
114+
throw new WebsocketConnectingException("Failed to connect to WebSocket server at " + host, e);
111115
}
112116
log.info("WebSocket client connected to: {}", host);
113117
}
Lines changed: 22 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,22 @@
1+
package info.unterrainer.websocketclient.exceptions;
2+
3+
public class WebsocketClosingException extends WebsocketException {
4+
5+
private static final long serialVersionUID = -8862710911083647793L;
6+
7+
public WebsocketClosingException() {
8+
super();
9+
}
10+
11+
public WebsocketClosingException(String message) {
12+
super(message);
13+
}
14+
15+
public WebsocketClosingException(Throwable cause) {
16+
super(cause);
17+
}
18+
19+
public WebsocketClosingException(String message, Throwable cause) {
20+
super(message, cause);
21+
}
22+
}
Lines changed: 22 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,22 @@
1+
package info.unterrainer.websocketclient.exceptions;
2+
3+
public class WebsocketConnectingException extends WebsocketException {
4+
5+
private static final long serialVersionUID = 2783771228373284782L;
6+
7+
public WebsocketConnectingException() {
8+
super();
9+
}
10+
11+
public WebsocketConnectingException(String message) {
12+
super(message);
13+
}
14+
15+
public WebsocketConnectingException(Throwable cause) {
16+
super(cause);
17+
}
18+
19+
public WebsocketConnectingException(String message, Throwable cause) {
20+
super(message, cause);
21+
}
22+
}
Lines changed: 23 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,23 @@
1+
package info.unterrainer.websocketclient.exceptions;
2+
3+
public class WebsocketException extends RuntimeException {
4+
5+
private static final long serialVersionUID = -700574755132411939L;
6+
7+
public WebsocketException() {
8+
super();
9+
}
10+
11+
public WebsocketException(String message) {
12+
super(message);
13+
}
14+
15+
public WebsocketException(Throwable cause) {
16+
super(cause);
17+
}
18+
19+
public WebsocketException(String message, Throwable cause) {
20+
super(message, cause);
21+
}
22+
23+
}
Lines changed: 22 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,22 @@
1+
package info.unterrainer.websocketclient.exceptions;
2+
3+
public class WebsocketSendingMessageException extends WebsocketException {
4+
5+
private static final long serialVersionUID = 6354296246039531090L;
6+
7+
public WebsocketSendingMessageException() {
8+
super();
9+
}
10+
11+
public WebsocketSendingMessageException(String message) {
12+
super(message);
13+
}
14+
15+
public WebsocketSendingMessageException(Throwable cause) {
16+
super(cause);
17+
}
18+
19+
public WebsocketSendingMessageException(String message, Throwable cause) {
20+
super(message, cause);
21+
}
22+
}

0 commit comments

Comments
 (0)