Trivial refactor

Author: J-Fields

src/error.ts

@@ -58,7 +58,7 @@ export enum ErrorCode {
   SliceRequiresAListOrBlobValue = 709,
   ListValueHasMoreItemsThanTarget = 710,
   ListValueHasNotEnoughItems = 711,
-  ArgumentOfMaxMustBeAListOrDictionary = 712,
+  ArgumentOfFuncMustBeAListOrDictionary = 712,
   ListRequired = 714,
   DictionaryRequired = 715,
   KeyNotPresentInDictionary = 716,
@@ -317,16 +317,10 @@ export class VimError extends Error {
   static ListValueHasNotEnoughItems(): VimError {
     return new VimError(ErrorCode.ListValueHasNotEnoughItems, 'List value has not enough items');
   }
-  static ArgumentOfMaxMustBeAListOrDictionary(): VimError {
+  static ArgumentOfFuncMustBeAListOrDictionary(func: string): VimError {
     return new VimError(
-      ErrorCode.ArgumentOfMaxMustBeAListOrDictionary,
-      'Argument of max() must be a List or Dictionary',
-    );
-  }
-  static ArgumentOfMinMustBeAListOrDictionary(): VimError {
-    return new VimError(
-      ErrorCode.ArgumentOfMaxMustBeAListOrDictionary,
-      'Argument of min() must be a List or Dictionary',
+      ErrorCode.ArgumentOfFuncMustBeAListOrDictionary,
+      `Argument of ${func} must be a List or Dictionary`,
     );
   }
   static ListRequired(): VimError {

src/vimscript/expression/evaluate.ts

@@ -965,7 +965,7 @@ export class EvaluationContext {
             }
             break;
           default:
-            throw VimError.ArgumentOfMaxMustBeAListOrDictionary();
+            throw VimError.ArgumentOfFuncMustBeAListOrDictionary(call.func);
         }
         return int(count);
       }
@@ -1370,7 +1370,7 @@ export class EvaluationContext {
         } else if (l?.type === 'dictionary') {
           values = [...l.items.values()];
         } else {
-          throw VimError.ArgumentOfMaxMustBeAListOrDictionary();
+          throw VimError.ArgumentOfFuncMustBeAListOrDictionary(call.func);
         }
         return int(values.length === 0 ? 0 : Math.max(...values.map(toInt)));
       }
@@ -1382,7 +1382,7 @@ export class EvaluationContext {
         } else if (l?.type === 'dictionary') {
           values = [...l.items.values()];
         } else {
-          throw VimError.ArgumentOfMinMustBeAListOrDictionary();
+          throw VimError.ArgumentOfFuncMustBeAListOrDictionary(call.func);
         }
         return int(values.length === 0 ? 0 : Math.min(...values.map(toInt)));
       }

test/vimscript/expression.test.ts

@@ -813,15 +813,15 @@ suite('Vimscript expressions', () => {
       exprTest('max([4, 3, 1, 5, 2])', { value: int(5) });
       exprTest('max(#{ten:10,twenty:20,thirty:30})', { value: int(30) });
       exprTest('max([1.2, 1.5])', { error: ErrorCode.UsingAFloatAsANumber });
-      exprTest("max('1,2,3')", { error: ErrorCode.ArgumentOfMaxMustBeAListOrDictionary });
+      exprTest("max('1,2,3')", { error: ErrorCode.ArgumentOfFuncMustBeAListOrDictionary });
     });
     suite('min', () => {
       exprTest('min([])', { value: int(0) });
       exprTest('min({})', { value: int(0) });
       exprTest('min([4, 3, 1, 5, 2])', { value: int(1) });
       exprTest('min(#{ten:10,twenty:20,thirty:30})', { value: int(10) });
       exprTest('min([1.2, 1.5])', { error: ErrorCode.UsingAFloatAsANumber });
-      exprTest("min('1,2,3')", { error: ErrorCode.ArgumentOfMaxMustBeAListOrDictionary });
+      exprTest("min('1,2,3')", { error: ErrorCode.ArgumentOfFuncMustBeAListOrDictionary });
     });
 
     suite('tolower', () => {