Add type hints for better code clarity and linting - #86
Open
meowmeowahr wants to merge 3 commits into
Open
meowmeowahr wants to merge 3 commits into
meowmeowahr wants to merge 3 commits into
Conversation
meowmeowahr
marked this pull request as draft
November 10, 2024 02:52
meowmeowahr
marked this pull request as ready for review
November 10, 2024 02:57
kalvdans
approved these changes
Nov 10, 2024
kalvdans
left a comment
kalvdans
left a comment
There was a problem hiding this comment.
Looks good to me!
Return values are still not annotated, but no problem to leave them for later.
(I have no merge rights to this repo, just a random user of the library)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These changes add proper type hints for all of the functions and sockets, for better code clarity and improved linting.
This would fix some issues, like the following, even thought the code runs as intended.
