Repository navigation
add a toggle for injection.mixin.features.v1_6_1.MixinAbstractContainerScreen #1322
Description
Activity
oops. does this matter?
Nope
@RaphiMC You wrote these mixins back then I think, what do you say?
I didn't know that shift clicking existed in <=1.6 versions. We could remove the mixin and accept desyncs in certain containers where shift clicking isn't possible or we get a list of all containers where shift clicking doesn't work and inject into each one to disable it there
I didn't know that shift clicking existed in <=1.6 versions. We could remove the mixin and accept desyncs in certain containers where shift clicking isn't possible or we get a list of all containers where shift clicking doesn't work and inject into each one to disable it there
the latter option would be nice
i'll investigate shift clicking in containers in legacy release versions in a couple hours and report backThank you, if you want, feel free to open a pull request.
i have done my research and here is what i found:
- inventory armor slots: shift click moves items in / out since 1.3.2, shift click only moves items out pre 1.3.2
- chests: shift click moves item in / out since beta 1.5 according to the minecraft wiki, i tested on 1.0
- brewing stand: shift click moves items in / out since 1.3.2, shift click only moves items out pre 1.3.2
- creative menu: no effect before 1.3.2
- survival inventory tab: shift click deletes item on 1.3.2 (vanilla bug?), shift click moves item like regular inventory post 1.3.2
- other tabs: shift click deletes item since 1.3.2
- enchantment tables: shift click moves in / out items since 1.3.2, shift click only moves items out pre 1.3.2
furnace: shift click moves items in / out since 1.3.2, shift click only moves item out pre 1.3.2already implemented in viafabricplus, though there are some jank related to shift clicking logs since in 1.3.2 logs don't shift click into fuel slot, causing desynccrafting table: shift click moves items out of the grid since 1.0 and only moves items into the grid since 1.15 (19w34a specifically) according to the minecraft wikiseems to be already implemented in viafabricplus
any containers not mentioned already have shift clicking in / out possible since their inception
about the pull request..
i'll probably try to make one in a couple of hours#1323
Problem Description
this mixin disables shift clicking items for all containers on version targets below 1.6.1 even though you can shift click items into certain containers on lower versions
(for example, on actual 1.2.5 you can shift click items into and out of chests, but on viafabricplus' 1.2.5 target, you cannot)
Proposed Solution
a new config option to disable this mixin's behavior would be great, but there are containers that you cannot shift click items into before certain versions
example: before 1.3.1, you cannot shift click items into the enchant slot on enchantment tables and you also cannot shift click armor into your armor slots while in your inventory (just disabling this mixin would cause desync when doing these actions)
new mixin(s) tailoring to shift clicking behavior in those versions would be ideal
Alternatives Considered
No response
Additional Information
No response