Skip to content

Commit 0761a69

Browse files
authored
Merge pull request #47 from Visual-Regression-Tracker/fix/ignore-areas
Fix ignore areas request field according to the backend contract
2 parents c43f5fd + 1688dbf commit 0761a69

File tree

5 files changed

+12
-12
lines changed

5 files changed

+12
-12
lines changed

src/main/java/io/visual_regression_tracker/sdk_java/IgnoredArea.java renamed to src/main/java/io/visual_regression_tracker/sdk_java/IgnoreAreas.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55

66
@Builder
77
@Data
8-
public class IgnoredArea {
8+
public class IgnoreAreas {
99

1010
private final Long x;
1111
private final Long y;

src/main/java/io/visual_regression_tracker/sdk_java/TestRunOptions.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,5 +13,5 @@ public class TestRunOptions {
1313
private final String viewport;
1414
private final String device;
1515
private final Float diffTollerancePercent;
16-
private final List<IgnoredArea> ignoredAreas;
16+
private final List<IgnoreAreas> ignoreAreas;
1717
}

src/main/java/io/visual_regression_tracker/sdk_java/VisualRegressionTracker.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -140,7 +140,7 @@ protected TestRunResponse submitTestRun(String name, String imageBase64,
140140
.viewport(testRunOptions.getViewport())
141141
.device(testRunOptions.getDevice())
142142
.diffTollerancePercent(testRunOptions.getDiffTollerancePercent())
143-
.ignoredAreas(testRunOptions.getIgnoredAreas())
143+
.ignoreAreas(testRunOptions.getIgnoreAreas())
144144
.build();
145145

146146
RequestBody body = RequestBody.create(JSON, gson.toJson(newTestRun));

src/main/java/io/visual_regression_tracker/sdk_java/request/TestRunRequest.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22

33
import java.util.List;
44

5-
import io.visual_regression_tracker.sdk_java.IgnoredArea;
5+
import io.visual_regression_tracker.sdk_java.IgnoreAreas;
66
import lombok.Builder;
77
import lombok.Getter;
88

@@ -19,5 +19,5 @@ public class TestRunRequest {
1919
private final String device;
2020
private final Float diffTollerancePercent;
2121
private final String branchName;
22-
private final List<IgnoredArea> ignoredAreas;
22+
private final List<IgnoreAreas> ignoreAreas;
2323
}

src/test/java/io/visual_regression_tracker/sdk_java/VisualRegressionTrackerTest.java

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -138,12 +138,12 @@ public void shouldSubmitTestRun() throws IOException, InterruptedException {
138138
.browser("Browser")
139139
.viewport("Viewport")
140140
.diffTollerancePercent(0.5f)
141-
.ignoredAreas(Arrays.asList(IgnoredArea.builder()
142-
.x(100L)
143-
.y(100L)
144-
.height(1L)
145-
.width(1L)
146-
.build()))
141+
.ignoreAreas(Arrays.asList(IgnoreAreas.builder()
142+
.x(100L)
143+
.y(100L)
144+
.height(1L)
145+
.width(1L)
146+
.build()))
147147
.build();
148148
TestRunRequest testRunRequest = TestRunRequest.builder()
149149
.projectId(PROJECT_ID)
@@ -156,7 +156,7 @@ public void shouldSubmitTestRun() throws IOException, InterruptedException {
156156
.viewport(testRunOptions.getViewport())
157157
.device(testRunOptions.getDevice())
158158
.diffTollerancePercent(testRunOptions.getDiffTollerancePercent())
159-
.ignoredAreas(testRunOptions.getIgnoredAreas())
159+
.ignoreAreas(testRunOptions.getIgnoreAreas())
160160
.build();
161161
TestRunResponse testRunResponse = TestRunResponse.builder()
162162
.status(TestRunStatus.UNRESOLVED)

0 commit comments

Comments
 (0)