d

d

Author: NextdoorPsycho

README.md

@@ -14,7 +14,7 @@ Version 3.1.0 — a from-scratch rewrite in [arcane_jaspr](https://github.com/Ar
 - **Validation** engine encoding the plugin's real parsing rules (lowercase registry keys, action source spellings, silent-zero pitfalls like `volume: 0`, legacy and MiniMessage formatting, hitbox overlap warnings).
 - **Image library**: upload validated PNG pixel art, preview exactly as the plugin rasterizes it, export `images.zip` laid out for `plugins/holoui/images/`. Server sync preserves captured PNG, JPEG, GIF, WebP and BMP bytes losslessly.
 - **Workspace**: folders, multiple menus and flow boards, atomic IndexedDB autosave with previous-transaction recovery and cross-tab conflict protection, undo/redo, templates, and searchable catalogs. Existing `holoui.workspace.v1` / `v2` localStorage data migrates once without deleting the rollback copy.
-- **Optional server sync**: capability links opened from `/holoui edit` import an exact menu or persistent world-board graph through the configured relay. Board publication retains the bound no-delete baseline and adds only menus reachable from the board root, leaving unrelated folder documents local. Sync status, conflicts and expiry stay visible; only the explicit **Publish to Server** action sends changes, and revision conflicts never overwrite local work. Links use the configured HTTPS relay (the plugin defaults to `https://sync.holoui.volmitsoftware.com/v1`) or a localhost HTTP development relay; an unreachable provider is reported without implying that a deployment is available.
+- **Optional server sync**: capability links opened from `/holoui edit` import an exact menu or persistent world-board graph through the configured relay. Board publication retains the bound no-delete baseline and adds only menus reachable from the board root, leaving unrelated folder documents local. **Publish to Server** appears beside Import and Export only during a live capability session; it durably saves a board project and hot-reloads the running board, while revision conflicts never overwrite local work. Links use the configured HTTPS relay (the plugin defaults to `https://sync.holoui.volmitsoftware.com/v1`) or a localhost HTTP development relay; an unreachable provider is reported without implying that a deployment is available.
 
 The editor itself remains a static client with no accounts. Normal authoring and autosave are local-only; opening a server-issued capability link enables bounded HTTPS requests to that link's relay until the tab disconnects. Capability tokens stay in the URL fragment and tab `sessionStorage`, never in workspace documents or exported bundles. If tab storage is blocked, the capability stays in the fragment and the sync bar tells you to copy the link before reloading.
 

lib/app.dart

@@ -709,9 +709,9 @@ class _AppState extends State<App> {
         onOpenValidation: () =>
             setState(() => _validationOpen = !_validationOpen),
         onCloseOverlay: _closeOverlay,
-        syncBar: _syncBinding == null
+        syncControls: _syncBinding == null
             ? null
-            : EditorSyncBar(
+            : EditorSyncControls(
                 status: _visibleSyncStatus,
                 subjectId: _syncBinding!.subjectId,
                 busy: _syncPublishing,

lib/components/shell/editor_shell.dart

@@ -31,6 +31,7 @@ import '../../services/image_library.dart';
 import '../../state/editor_scope.dart';
 import '../../state/editor_store.dart';
 import 'command_palette.dart';
+import 'editor_sync_bar.dart';
 import 'key_listener.dart';
 import 'keyboard_shortcuts.dart';
 import 'pane_dom.dart';
@@ -65,7 +66,7 @@ class EditorShell extends StatefulWidget {
     this.onOpenHelp,
     this.onOpenSettings,
     this.onOpenValidation,
-    this.syncBar,
+    this.syncControls,
     this.onCloseOverlay,
     this.onToggleTheme,
     this.darkMode = true,
@@ -101,7 +102,7 @@ class EditorShell extends StatefulWidget {
   final void Function()? onOpenHelp;
   final void Function()? onOpenSettings;
   final void Function()? onOpenValidation;
-  final Widget? syncBar;
+  final EditorSyncControls? syncControls;
 
   /// Escape handler for whichever dialog or sheet the owner has open.
   final void Function()? onCloseOverlay;
@@ -366,10 +367,18 @@ class _EditorShellState extends State<EditorShell> {
       onCloseOverlay: _escapeOverlay,
       child: dom.div(
         id: 'hui-shell',
-        classes: component.syncBar == null ? 'hui-shell' : 'hui-shell has-sync',
+        classes: component.syncControls == null
+            ? 'hui-shell'
+            : 'hui-shell has-sync',
         <Widget>[
-          TopBar(intents: intents, apple: _apple, darkMode: component.darkMode),
-          if (component.syncBar != null) component.syncBar!,
+          TopBar(
+            intents: intents,
+            syncControls: component.syncControls,
+            apple: _apple,
+            darkMode: component.darkMode,
+          ),
+          if (component.syncControls != null)
+            EditorSyncBar(controls: component.syncControls!),
           dom.div(classes: 'hui-shell-body', <Widget>[
             dom.aside(
               classes: 'hui-pane hui-rail',

lib/components/shell/editor_sync_bar.dart

@@ -5,16 +5,15 @@ import 'package:jaspr/dom.dart' as dom;
 
 import '../../services/editor_sync.dart';
 
-class EditorSyncBar extends StatelessWidget {
-  const EditorSyncBar({
+class EditorSyncControls {
+  const EditorSyncControls({
     required this.status,
     required this.subjectId,
     required this.busy,
     required this.onPublish,
     required this.onCopyLink,
     required this.onDisconnect,
     this.message,
-    super.key,
   });
 
   final EditorSyncStatus status;
@@ -25,38 +24,62 @@ class EditorSyncBar extends StatelessWidget {
   final VoidCallback onCopyLink;
   final VoidCallback onDisconnect;
 
+  bool get canPublish => busy == false && canPublishEditorSyncStatus(status);
+
+  String get publishLabel => busy ? 'Publishing…' : 'Publish to Server';
+
+  String get publishHint => switch (status) {
+    EditorSyncStatus.connected =>
+      'Publish the connected $subjectId project for server validation and apply.',
+    EditorSyncStatus.applied =>
+      'Publish new changes to the connected $subjectId server project.',
+    EditorSyncStatus.rejected =>
+      'The last publication was rejected. Fix the reported issue, then publish again.',
+    EditorSyncStatus.pending =>
+      'The server is still validating and applying the current publication.',
+    EditorSyncStatus.conflict =>
+      'Resolve the server revision conflict before publishing again.',
+    EditorSyncStatus.expired =>
+      'This server capability expired. Create a new link in Minecraft.',
+    EditorSyncStatus.revoked =>
+      'This server capability was revoked. Create a new link in Minecraft.',
+    EditorSyncStatus.disconnected =>
+      'This tab is disconnected from the server project.',
+    EditorSyncStatus.unavailable =>
+      'The configured sync relay is currently unavailable.',
+  };
+}
+
+class EditorSyncBar extends StatelessWidget {
+  const EditorSyncBar({required this.controls, super.key});
+
+  final EditorSyncControls controls;
+
   @override
   Widget build(BuildContext context) => dom.div(
-    classes: 'hui-sync-bar is-${status.name}',
+    classes: 'hui-sync-bar is-${controls.status.name}',
     attributes: const <String, String>{'role': 'status', 'aria-live': 'polite'},
     <Widget>[
       dom.div(classes: 'hui-sync-identity', <Widget>[
         ArcaneIcon.cloud(size: IconSize.sm),
-        dom.strong(<Widget>[Text(_label(status))]),
-        dom.code(<Widget>[Text(subjectId)]),
-        if (message != null) dom.span(<Widget>[Text(message!)]),
+        dom.strong(<Widget>[Text(_label(controls.status))]),
+        dom.code(<Widget>[Text(controls.subjectId)]),
+        if (controls.message != null)
+          dom.span(<Widget>[Text(controls.message!)]),
       ]),
       dom.div(classes: 'hui-sync-actions', <Widget>[
         Button.ghost(
           size: ButtonSize.sm,
-          onPressed: onCopyLink,
+          onPressed: controls.onCopyLink,
           icon: ArcaneIcon.copy(size: IconSize.sm),
           label: 'Copy link',
         ),
         Button.ghost(
           size: ButtonSize.sm,
-          onPressed: onDisconnect,
+          onPressed: controls.onDisconnect,
           icon: ArcaneIcon.unlink(size: IconSize.sm),
           label: 'Disconnect',
         ),
-        Button(
-          size: ButtonSize.sm,
-          variant: ButtonVariant.primary,
-          disabled: busy || !canPublishEditorSyncStatus(status),
-          onPressed: busy ? null : onPublish,
-          icon: ArcaneIcon.cloudUpload(size: IconSize.sm),
-          label: busy ? 'Publishing…' : 'Publish to Server',
-        ),
       ]),
     ],
   );

lib/components/shell/top_bar.dart

@@ -15,6 +15,7 @@ import '../../state/editor_store.dart';
 import '../../state/workspace.dart';
 import '../common/class_names.dart';
 import 'bar_menu.dart';
+import 'editor_sync_bar.dart';
 import 'shell_intents.dart';
 import 'shell_keys.dart';
 import 'store_selector.dart';
@@ -23,12 +24,14 @@ import 'view_switcher.dart';
 class TopBar extends StatefulWidget {
   const TopBar({
     required this.intents,
+    this.syncControls,
     this.apple = false,
     this.darkMode = true,
     super.key,
   });
 
   final ShellIntents intents;
+  final EditorSyncControls? syncControls;
   final bool apple;
   final bool darkMode;
 
@@ -75,6 +78,14 @@ class _TopBarState extends State<TopBar> {
       ..write('|')
       ..write(_store.redoLabel)
       ..write('|')
+      ..write(component.syncControls?.status.name)
+      ..write('|')
+      ..write(component.syncControls?.subjectId)
+      ..write('|')
+      ..write(component.syncControls?.busy)
+      ..write('|')
+      ..write(component.syncControls?.message)
+      ..write('|')
       ..write(workspace.activeId);
     for (final WorkspaceDoc doc in workspace.recent) {
       buffer
@@ -156,6 +167,17 @@ class _TopBarState extends State<TopBar> {
             onPressed: _intents.exportMenu,
             disabled: !_store.canTransferDocument,
           ),
+          if (component.syncControls != null)
+            _action(
+              icon: ArcaneIcon.cloudUpload(size: IconSize.sm),
+              label: component.syncControls!.publishLabel,
+              hint: component.syncControls!.publishHint,
+              variant: component.syncControls!.canPublish
+                  ? ButtonVariant.primary
+                  : ButtonVariant.outline,
+              onPressed: component.syncControls!.onPublish,
+              disabled: component.syncControls!.canPublish == false,
+            ),
           _action(
             icon: ArcaneIcon.copy(size: IconSize.sm),
             label: 'Copy menu JSON',

test/editor_sync_bar_test.dart

@@ -0,0 +1,40 @@
+import 'package:holoui_editor/components/shell/editor_sync_bar.dart';
+import 'package:holoui_editor/services/editor_sync.dart';
+import 'package:test/test.dart';
+
+void main() {
+  group('editor sync publish controls', () {
+    test('connected and applied projects can publish', () {
+      expect(_controls(EditorSyncStatus.connected).canPublish, isTrue);
+      expect(_controls(EditorSyncStatus.applied).canPublish, isTrue);
+    });
+
+    test('busy and pending projects cannot publish', () {
+      expect(
+        _controls(EditorSyncStatus.connected, busy: true).canPublish,
+        isFalse,
+      );
+      expect(_controls(EditorSyncStatus.pending).canPublish, isFalse);
+    });
+
+    test('rejected projects explain that publishing can be retried', () {
+      final EditorSyncControls controls = _controls(EditorSyncStatus.rejected);
+
+      expect(controls.canPublish, isTrue);
+      expect(controls.publishLabel, 'Publish to Server');
+      expect(controls.publishHint, contains('publish again'));
+    });
+  });
+}
+
+EditorSyncControls _controls(EditorSyncStatus status, {bool busy = false}) =>
+    EditorSyncControls(
+      status: status,
+      subjectId: 'lobby-board',
+      busy: busy,
+      onPublish: _noop,
+      onCopyLink: _noop,
+      onDisconnect: _noop,
+    );
+
+void _noop() {}