Modernize used node and a few other packages, add eslint and enforce sorting includes

* Add eslint and sort includes

This is code health CL, it foster code health by adding linter that can
verify keeping consistent style and avoiding some kind of error. It also
adds prettier plugin that sorts includes when as usual run with `npm run
lint` and fixes some audit issues. The code also updates developer
dependency packages versions and the node version.

* Updating package-lock.json

* Undo removing line

* Make package-lock.json smaller

* Update Luke's name

Co-authored-by: Zgroza (Luke) Klimek <zgroza@google.com>

* Update node and prettier version

* Fixing Editor's Copy and prettier workflow check

* Prettier workflow problems

* Try with older prettier-actions

* Add plugin to prettier on command level

* Customized worflow to workaround prettier-actions external plugins bug

* Sorry, i cannot test workflow locally...

* Sorry, I cannot test workflow locally... p.2

* Another workflow try...

* I'll squash it later...

* Typo

* Use npx

* Use glob path

* Maybe separate test will help

* Maybe separate test will help p.2

* Where it starts?

* Simple path typo

* Use working directory of prettier actions

* Manual workflow

* Manual workflow nit

* Manual workflow nit2

* No cache - simple better

---------

Co-authored-by: Zgroza (Luke) Klimek <zgroza@google.com>

Author: rferens

.github/workflows/build.yml

@@ -14,7 +14,7 @@ jobs:
     runs-on: ubuntu-latest
     strategy:
       matrix:
-        node-version: [16, 18, 20]
+        node-version: [20, 22, 24]
     steps:
       - uses: actions/checkout@v2
       - uses: actions/setup-node@v3
@@ -28,7 +28,7 @@ jobs:
     runs-on: ubuntu-latest
     strategy:
       matrix:
-        node-version: [16, 18, 20]
+        node-version: [20, 22, 24]
     steps:
       - uses: actions/checkout@v2
       - uses: actions/setup-node@v3
@@ -38,13 +38,38 @@ jobs:
       - run: npm --prefix ./js/sign run build
       - run: npm --prefix ./js/sign test
 
-  prettier:
+  prettier-wbn:
     runs-on: ubuntu-latest
+    defaults:
+      run:
+        working-directory: js/bundle
     steps:
-      - uses: actions/checkout@v2
-      - uses: creyD/prettier_action@v4.3
+      - uses: actions/checkout@v4
+      - name: Setup Node.js
+        uses: actions/setup-node@v4
+        with:
+          node-version: 22
+      - name: Install Prettier
+        run: |
+          npm install prettier@3.5 --no-save
+      - name: Run Prettier Check
+        run: |
+            npx prettier --check . --ignore-unknown
+
+  prettier-wbn-sign:
+    runs-on: ubuntu-latest
+    defaults:
+      run:
+        working-directory: js/sign
+    steps:
+      - uses: actions/checkout@v4
+      - name: Setup Node.js
+        uses: actions/setup-node@v4
         with:
-          prettier_options: --write **/*.{js,ts}
-          only_changed: True
-          dry: True
-          prettier_version: 2.7.1
+          node-version: 22
+      - name: Install Prettier and Plugins
+        run: |
+          npm install prettier@3.5 @ianvs/prettier-plugin-sort-imports --no-save
+      - name: Run Prettier Check
+        run: |
+            npx prettier --check . --ignore-unknown --plugin=@ianvs/prettier-plugin-sort-imports

.github/workflows/ghpages.yml

@@ -33,7 +33,7 @@ jobs:
         echo "::set-output name=path::$HOME/.cache/xml2rfc"
         date -u "+::set-output name=date::%FT%T"
     - name: "Cache References"
-      uses: actions/cache@v2
+      uses: actions/cache@v4
       with:
         path: ${{ steps.cache-setup.outputs.path }}
         key: refcache-${{ steps.cache-setup.outputs.date }}
@@ -59,11 +59,11 @@ jobs:
         GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
 
     - name: "Save HTML"
-      uses: actions/upload-artifact@v2
+      uses: actions/upload-artifact@v4
       with:
         path: "*.html"
 
     - name: "Save Text"
-      uses: actions/upload-artifact@v2
+      uses: actions/upload-artifact@v4
       with:
         path: "*.txt"

.github/workflows/publish.yml

@@ -24,7 +24,7 @@ jobs:
         echo "::set-output name=path::$HOME/.cache/xml2rfc"
         date -u "+::set-output name=date::%FT%T"
     - name: "Cache References"
-      uses: actions/cache@v2
+      uses: actions/cache@v4
       with:
         path: ${{ steps.cache-setup.outputs.path }}
         key: refcache-${{ steps.date.outputs.date }}

js/bundle/package-lock.json

@@ -46,17 +46,18 @@
     "@types/node": "^12.7.11",
     "esbuild": "^0.25.0",
     "jasmine": "^4.2.1",
-    "prettier": "2.8.0",
+    "prettier": "3.5.3",
     "typescript": "^4.7.3"
   },
   "engines": {
-    "node": ">= 12.0.0"
+    "node": ">= 20.0.0"
   },
   "prettier": {
     "tabWidth": 2,
     "semi": true,
     "singleQuote": true,
     "printWidth": 80,
-    "proseWrap": "always"
+    "proseWrap": "always",
+    "trailingComma": "es5"
   }
 }

js/bundle/package.json

@@ -2,7 +2,7 @@ export const B1 = 'b1';
 export const B2 = 'b2';
 export const DEFAULT_VERSION = B2;
 export const APPROVED_VERSIONS = [B1, B2] as const;
-export type FormatVersion = typeof APPROVED_VERSIONS[number];
+export type FormatVersion = (typeof APPROVED_VERSIONS)[number];
 
 export function isApprovedVersion(param: any): param is FormatVersion {
   return APPROVED_VERSIONS.includes(param);

js/bundle/src/constants.ts

@@ -2,3 +2,4 @@ lib
 *.wbn
 *.swbn
 testdata
+README.md

js/sign/.prettierignore

@@ -0,0 +1,31 @@
+// @ts-check
+
+import eslint from '@eslint/js';
+import { defineConfig } from 'eslint/config';
+import globals from 'globals';
+import tseslint from 'typescript-eslint';
+
+export default defineConfig(
+  {
+    ignores: ['lib/**', 'node_modules/**'],
+  },
+  eslint.configs.recommended,
+  ...tseslint.configs.recommended,
+  {
+    files: ['**/*.ts', '**/*.js'],
+    languageOptions: {
+      globals: {
+        ...globals.node,
+      },
+    },
+  },
+  // Test specific rules/globals
+  {
+    files: ['**/tests/**/*.js', '**/*_test.js'],
+    languageOptions: {
+      globals: {
+        ...globals.jasmine,
+      },
+    },
+  }
+);