fix

Author: camillobruni

suites-experimental/javascript-wc-indexeddb/dist/src/speedometer-utils/benchmark.mjs

@@ -14,10 +14,10 @@ export class BenchmarkStep {
         this.ignoreResult = ignoreResult;
     }
 
-    async runAndRecord(params, suite, test, callback) {
+    async runAndRecord(params, suite, test) {
         const TestRunnerClass = params.useAsyncSteps ? AsyncTestRunner : TestRunner;
         const type = params.useAsyncSteps ? "async" : "sync";
-        const testRunner = new TestRunnerClass(null, null, params, suite, test, callback, type);
+        const testRunner = new TestRunnerClass(null, null, params, suite, test, type);
         const result = await testRunner.runTest();
         return result;
     }

suites-experimental/javascript-wc-indexeddb/src/speedometer-utils/benchmark.mjs

@@ -14,10 +14,10 @@ export class BenchmarkStep {
         this.ignoreResult = ignoreResult;
     }
 
-    async runAndRecord(params, suite, test, callback) {
+    async runAndRecord(params, suite, test) {
         const TestRunnerClass = params.useAsyncSteps ? AsyncTestRunner : TestRunner;
         const type = params.useAsyncSteps ? "async" : "sync";
-        const testRunner = new TestRunnerClass(null, null, params, suite, test, callback, type);
+        const testRunner = new TestRunnerClass(null, null, params, suite, test, type);
         const result = await testRunner.runTest();
         return result;
     }

suites/todomvc/vanilla-examples/javascript-web-components/dist/src/speedometer-utils/benchmark.mjs

@@ -13,8 +13,8 @@ export class BenchmarkStep {
         this.run = run;
     }
 
-    async runAndRecord(params, suite, test, callback) {
-        const testRunner = new TestRunner(null, null, params, suite, test, callback);
+    async runAndRecord(params, suite, test) {
+        const testRunner = new TestRunner(null, null, params, suite, test);
         const result = await testRunner.runTest();
         return result;
     }

tests/unittests/benchmark-runner.mjs

@@ -1,6 +1,7 @@
-import { BenchmarkRunner } from "../../resources/benchmark-runner.mjs";
+import { BenchmarkRunner, BenchmarkTestStep } from "../../resources/benchmark-runner.mjs";
 import { SuiteRunner } from "../../resources/suite-runner.mjs";
-import { StepRunner } from "../../resources/shared/step-runner.mjs";
+import { StepRunner, AsyncStepRunner } from "../../resources/shared/step-runner.mjs";
+import { STEP_SCHEDULER_LOOKUP } from "../../resources/shared/step-scheduler.mjs";
 import { defaultParams } from "../../resources/shared/params.mjs";
 
 function TEST_FIXTURE(name) {
@@ -109,8 +110,7 @@ describe("BenchmarkRunner", () => {
                 _loadFrameStub = stub(SuiteRunner.prototype, "_loadFrame").callsFake(async () => null);
                 _appendFrameStub = stub(runner, "_appendFrame").callsFake(async () => null);
                 _removeFrameStub = stub(runner, "_removeFrame").callsFake(() => null);
-                for (const suite of runner._suites)
-                    spy(suite, "prepare");
+                runner._suites.forEach((suite) => spy(suite, "prepare"));
                 expect(runner._suites).not.to.have.length(0);
                 await runner.runAllSuites();
             });
@@ -256,4 +256,52 @@ describe("BenchmarkRunner", () => {
             });
         });
     });
+
+    describe("StepRunner", () => {
+        const suite = SUITES_FIXTURE[0];
+        const params = { measurementMethod: "raf", warmupBeforeSync: 0 };
+
+        it("should run StepRunner and return { syncTime, asyncTime }", async () => {
+            const step = new BenchmarkTestStep("SyncStep", sinon.stub());
+            const runner = new StepRunner(null, null, params, suite, step, "default");
+            const { syncTime, asyncTime } = await runner.runStep();
+            expect(typeof syncTime).to.equal("number");
+            expect(typeof asyncTime).to.equal("number");
+            assert.calledOnce(step.run);
+        });
+
+        it("should run AsyncStepRunner and return { syncTime, asyncTime }", async () => {
+            const asyncStep = new BenchmarkTestStep(
+                "AsyncStep",
+                sinon.stub().callsFake(async () => {})
+            );
+            const runner = new AsyncStepRunner(null, null, params, suite, asyncStep, "async");
+            const { syncTime, asyncTime } = await runner.runStep();
+            expect(typeof syncTime).to.equal("number");
+            expect(typeof asyncTime).to.equal("number");
+            assert.calledOnce(asyncStep.run);
+        });
+    });
+
+    describe("StepScheduler", () => {
+        it("should schedule callbacks and resolve in RAFStepScheduler", async () => {
+            const syncCallback = sinon.stub();
+            const asyncCallback = sinon.stub();
+            const scheduler = new STEP_SCHEDULER_LOOKUP.raf(syncCallback, asyncCallback, { waitBeforeSync: 0 });
+            const result = await scheduler.start();
+            expect(result).to.be(undefined);
+            assert.calledOnce(syncCallback);
+            assert.calledOnce(asyncCallback);
+        });
+
+        it("should respect waitBeforeSync when starting scheduler", async () => {
+            const syncCallback = sinon.stub();
+            const asyncCallback = sinon.stub();
+            const scheduler = new STEP_SCHEDULER_LOOKUP.raf(syncCallback, asyncCallback, { waitBeforeSync: 10 });
+            const result = await scheduler.start();
+            expect(result).to.be(undefined);
+            assert.calledOnce(syncCallback);
+            assert.calledOnce(asyncCallback);
+        });
+    });
 });