Skip to content

Conversation

@gvol
Copy link

@gvol gvol commented Jan 14, 2021

As usual when writing elisp, I mostly stopped once I got it working, so feel free to make me fix a few things that don't match your code style or quality.

In particular, I wasn't sure if all should be part of the introduced alist or not—I could go either way. I left it as being special, but I'm happy to change it. I'm also not sure what order the buttons should be in. I kind of think they type and glob should be last since they are the most ad-hoc, but I imagine that I will set deadgrep-file-type-alist by project, so it might also be nice to have the "global" one be in more stable positions.

Also, I'm happy to add more tests if you think they are warranted. I couldn't find any other tests about creating or interacting buttons for example.

I do have papers signed with the FSF in case that's a concern.

@gvol
Copy link
Author

gvol commented Jan 16, 2021

Sorry, I hate to bug you, @Wilfred, but do you know what I should do to get the tests passing? I've never actually used Travis before and Cask only a little.

@Wilfred
Copy link
Owner

Wilfred commented Jan 28, 2021

I've moved the tests from Travis to GitHub actions, and they should now be passing :)

@gvol
Copy link
Author

gvol commented Jan 29, 2021

Okay, I rebased on master. Hopefully, they'll pass now.

@gvol
Copy link
Author

gvol commented Feb 11, 2021

Sorry it took me so long to get back to this. I rebased on master again and updated my tests for changes on master.

@gvol
Copy link
Author

gvol commented Mar 15, 2021

Thoughts, @Wilfred?

@gvol
Copy link
Author

gvol commented Sep 15, 2021

I've been using this for a while now, and I find it extremely useful. Is there anything you would like me to do?

@arafel
Copy link

arafel commented Aug 16, 2023

Hi - just wondering if there was any chance of this being merged? deadgrep's really useful, but the company I work for uses '.inc' for a lot of their Makefiles - it would be really useful to be able to add a type which searched those as well as normal Makefile names. :-)

@gvol
Copy link
Author

gvol commented Aug 16, 2023

Here's what the results might look like, just as an example:
Screen Shot 2023-08-16 at 08 13 13

@gvol
Copy link
Author

gvol commented Sep 10, 2023

Since you recently merged #138, maybe I'll gently poke you about this one as well. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants