test: improve test-c8 logging; use bash -lc + pipefail to show failing test output and propagate c8 exit codes

Author: WillyEverGreen

tools/make/lib/test-cov/c8.mk

@@ -86,22 +86,21 @@ c8_flags += $(C8_FLAGS)
 #/
 test-c8: $(NODE_MODULES)
 ifeq ($(FAIL_FAST), true)
-	$(QUIET) $(FIND_TESTS_CMD) | grep '^[\/]\|^[a-zA-Z]:[/\]' | while read -r test; do \
+	$(FIND_TESTS_CMD) | grep '^[\/]\|^[a-zA-Z]:[/\\]' | while read -r test; do \
 		echo ''; \
 		echo "Running test: $$test"; \
-		NODE_ENV="$(NODE_ENV_TEST)" \
-		NODE_PATH="$(NODE_PATH_TEST)" \
-		TEST_MODE=coverage \
-		$(C8) $(c8_flags) $(NODE) $$test | $(TAP_REPORTER) || exit 1; \
+		# Run each test under bash with pipefail so we capture the c8 exit status when piping to the TAP reporter.
+		bash -lc 'set -o pipefail; NODE_ENV="$(NODE_ENV_TEST)" NODE_PATH="$(NODE_PATH_TEST)" TEST_MODE=coverage $(C8) $(c8_flags) $(NODE) "$$test" 2>&1 | $(TAP_REPORTER)'; \
+		rc=$$?; \
+		if [ $$rc -ne 0 ]; then echo "TEST_FAILED: $$test (exit $$rc)"; exit $$rc; fi; \
 	done
 else
-	$(QUIET) $(FIND_TESTS_CMD) | grep '^[\/]\|^[a-zA-Z]:[/\]' | while read -r test; do \
+	$(FIND_TESTS_CMD) | grep '^[\/]\|^[a-zA-Z]:[/\\]' | while read -r test; do \
 		echo ''; \
 		echo "Running test: $$test"; \
-		NODE_ENV="$(NODE_ENV_TEST)" \
-		NODE_PATH="$(NODE_PATH_TEST)" \
-		TEST_MODE=coverage \
-		$(C8) $(c8_flags) $(NODE) $$test | $(TAP_REPORTER) || echo 'Tests failed.'; \
+		bash -lc 'set -o pipefail; NODE_ENV="$(NODE_ENV_TEST)" NODE_PATH="$(NODE_PATH_TEST)" TEST_MODE=coverage $(C8) $(c8_flags) $(NODE) "$$test" 2>&1 | $(TAP_REPORTER)'; \
+		rc=$$?; \
+		if [ $$rc -ne 0 ]; then echo "Tests failed: $$test (exit $$rc)"; fi; \
 	done
 endif