Fix tests, !== ! == ===

dmsnell · dmsnell · commit 4c652adee318 · 2024-08-20T18:41:40.000-07:00
diff --git a/src/wp-includes/html-api/class-wp-html-processor.php b/src/wp-includes/html-api/class-wp-html-processor.php
@@ -308,10 +308,9 @@ public static function create_fragment( $html, $context = '<body>', $encoding =
 		}
 
 		$context_node = self::parse_context_element( $context );
-		var_dump( $context_node );
 		if ( null === $context_node ) {
 			_doing_it_wrong(
-				__FUNCTION__,
+				__METHOD__,
 				__( 'The context argument must be an HTML start tag.' ),
 				'6.7.0'
 			);
@@ -320,7 +319,7 @@ public static function create_fragment( $html, $context = '<body>', $encoding =
 
 		if ( self::is_void( $context_node[0] ) ) {
 			_doing_it_wrong(
-				__FUNCTION__,
+				__METHOD__,
 				__( 'The context argument may not specify a void element.' ),
 				'6.7.0'
 			);
@@ -329,7 +328,7 @@ public static function create_fragment( $html, $context = '<body>', $encoding =
 
 		if ( in_array( $context_node[0], array( 'IFRAME', 'NOEMBED', 'NOFRAMES', 'SCRIPT', 'STYLE', 'TEXTAREA', 'TITLE', 'XMP' ), true ) ) {
 			_doing_it_wrong(
-				__FUNCTION__,
+				__METHOD__,
 				__( 'The context argument may not specify a self-contained element.' ),
 				'6.7.0'
 			);
@@ -387,7 +386,7 @@ public static function create_fragment( $html, $context = '<body>', $encoding =
 	 * @return array|null Element name and associative array of attributes if parsed, otherwise NULL.
 	 */
 	private static function parse_context_element( $context = '<body>' ): ?array {
-		if ( '<body>' !== $context ) {
+		if ( '<body>' === $context ) {
 			return array( 'BODY', array() );
 		}
 
diff --git a/tests/phpunit/tests/html-api/wpHtmlProcessorFragmentParsing.php b/tests/phpunit/tests/html-api/wpHtmlProcessorFragmentParsing.php
@@ -23,6 +23,8 @@ class Tests_HtmlApi_WpHtmlProcessorFragmentParsing extends WP_UnitTestCase {
 	 *
 	 * @dataProvider data_invalid_fragment_contexts
 	 *
+	 * @expectedIncorrectUsage WP_HTML_Processor::create_fragment
+	 *
 	 * @param string $context Invalid context node for fragment parser.
 	 */
 	public function test_rejects_invalid_fragment_contexts( string $context ) {

Original file line number	Diff line number	Diff line change
`@@ -23,6 +23,8 @@ class Tests_HtmlApi_WpHtmlProcessorFragmentParsing extends WP_UnitTestCase {`
`23`	`23`	`*`
`24`	`24`	`* @dataProvider data_invalid_fragment_contexts`
`25`	`25`	`*`
	`26`	`+ * @expectedIncorrectUsage WP_HTML_Processor::create_fragment`
	`27`	`+ *`
`26`	`28`	`* @param string $context Invalid context node for fragment parser.`
`27`	`29`	`*/`
`28`	`30`	`public function test_rejects_invalid_fragment_contexts( string $context ) {`