-
Notifications
You must be signed in to change notification settings - Fork 322
Open
Description
Occasionally, I come across leftover code from earlier implementations that we could probably clean up.
I'd prefer not to include these cleanups in unrelated PR to avoid confusion.
Instead, we could use this issue to track them as we find them and gradually clean up the project over time.
Cleanup
-
passWithNoTests
property in project.json test is a Jest property. NX vitest executor schema here. Other properties are also no longer valid. [ like configurations that can also be removed from ci.yml file ] - Vite cache.dir is deprecated, use cacheDir instead.
-
WITH_NODEFS
incompile/build.js
seems to be unused now. - Remove obsolete PHP version in
supported-php-versions.mjs
- Remove commented
describe.each(SupportedPHPVersions)(
inphp-networking.spec.ts
- Remove obsolete
build
property inphp-wasm/node/vite.config.js
- Remove unnecessary
throw new Error('Unsupported PHP version ${version}');
inget-php-loader-module.ts
- Remove ASYNCIFY_ONLY with UNPREFIXED duplicatas since pointer casting is disabled now in
php/Dockerfile
on line2008
- Remove "Asyncify onlylist contained a non-existing function name" lists
- Correct
@php-wasm/universal
infs-journal/package.json
- Unused
import { createRequire } from 'module';
inpackage/php-wasm/node/build.js
- Remove
setPluginProxyURL
inpackages/playground/blueprints/src/index.ts
, deprecated.
Addition
- Refactor
followSymlinks
insideload-runtime
to a separate file. -
getPHPLoaderModule
inload-runtime
should be called first, if a PHP version doesn't exist. - There is no removal of dist directories for
libcurl
incompile/Makefile
:rm -rf ./libcurl/jspi/dist & rm -rf ./libcurl/asyncify/dist
- Replace
php.run()
withphp.runStream()
everywhere in project. - Add
dev
command inproject.json
to run as JSPI or ASYNCIFY
adamziel