Skip to content

Miscellaneous - Cleanup of leftover code or addition of missing code segments. #2235

@mho22

Description

@mho22

Occasionally, I come across leftover code from earlier implementations that we could probably clean up.

I'd prefer not to include these cleanups in unrelated PR to avoid confusion.
Instead, we could use this issue to track them as we find them and gradually clean up the project over time.

Cleanup

  • passWithNoTests property in project.json test is a Jest property. NX vitest executor schema here. Other properties are also no longer valid. [ like configurations that can also be removed from ci.yml file ]
  • Vite cache.dir is deprecated, use cacheDir instead.
  • WITH_NODEFS in compile/build.js seems to be unused now.
  • Remove obsolete PHP version in supported-php-versions.mjs
  • Remove commented describe.each(SupportedPHPVersions)( in php-networking.spec.ts
  • Remove obsolete build property in php-wasm/node/vite.config.js
  • Remove unnecessary throw new Error('Unsupported PHP version ${version}'); in get-php-loader-module.ts
  • Remove ASYNCIFY_ONLY with UNPREFIXED duplicatas since pointer casting is disabled now in php/Dockerfile on line 2008
  • Remove "Asyncify onlylist contained a non-existing function name" lists
  • Correct @php-wasm/universal in fs-journal/package.json
  • Unused import { createRequire } from 'module'; in package/php-wasm/node/build.js
  • Remove setPluginProxyURL in packages/playground/blueprints/src/index.ts, deprecated.

Addition

  • Refactor followSymlinks inside load-runtime to a separate file.
  • getPHPLoaderModule in load-runtime should be called first, if a PHP version doesn't exist.
  • There is no removal of dist directories for libcurl in compile/Makefile : rm -rf ./libcurl/jspi/dist & rm -rf ./libcurl/asyncify/dist
  • Replace php.run() with php.runStream() everywhere in project.
  • Add dev command in project.json to run as JSPI or ASYNCIFY

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions