[Playground CLI] Use Blueprints v2 #2238
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Functions like proc_open,popen,curl_exec,curl_multi_exec were not supported long time ago, but now they are. There's no good reason to disable them by default anymore. Therefore, let's enable them.
… seem to respond after 5 seconds.
…e in the php.js build
This is a first stab at running Blueprints.phar in Playground CLI. It seems to be correctly installing the WordPress site. Some of these items might be better suited for other PRs. * Code structure – Make the spawn handler generic, move it to some useful package. * Clearly separate bootWordPress from bootRequestHandler. Perhaps relocate the latter. * Fix playground.cli() method to avoid mocking cliBootstrapScript inline * Report Blueprint runner progress live, not after the work is done. We may need a callback or a ReadableStream to get the stdout bytes live. * Find a way of telling the PHP instance what is the current CWD (to avoid the chdir() call) * Propagate CLI args / site URL to runV2() call cc @bgrgicak @akirk
…prints.phar reject the CLI args – just the error message.
…by the Blueprints v2 runner
Use custom decides at /internal/stdout, /internal/stderr, and /internal/headers to expose the PHP output data before the request finishes. Introduce a StreamedPHPResponse class to consume that data as promises and ReadableStream instances
adamziel
changed the base branch from
php-wasm-support-any-php-subprocess
to
trunk
1 task
|
superseded by #2281 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a first stab at running Blueprints.phar in Playground CLI. It seems to be correctly installing the WordPress site 🎉
Summary of changes
cc @bgrgicak @akirk @adamziel @wojtekn