[!457] - Resolve "Remove plugin-kafka-spark-old plugin"

# New features and improvements

Removed empty module `plugin-kafka-spark-old`

# Breaking changes

None.

# Migration

None.

# Bug fixes

None.

# How this feature was tested

No tests needed.

# Related issue

Closes #572

Author: agilelab-tmnd1991

build.sbt

@@ -135,17 +135,6 @@ lazy val plugin_kafka_spark = Project("wasp-plugin-kafka-spark", file("plugin-ka
   .dependsOn(consumers_spark % dependCompileOnCompileAndTestOnTest)
   .settings(libraryDependencies ++= dependencies.pluginKafkaSparkDependencies)
 
-lazy val plugin_kafka_spark_old = Project("wasp-plugin-kafka-spark-old", file("plugin-kafka-spark-old"))
-  .settings(settings.commonSettings: _*)
-  .settings(
-    Compile / scalaSource := baseDirectory.value / ".." / "plugin-kafka-spark" / "src" / "main" / "scala",
-    Test / scalaSource := baseDirectory.value / ".." / "plugin-kafka-spark" / "src" / "test" / "scala",
-    Test / unmanagedSourceDirectories += baseDirectory.value / ".." / "plugin-kafka-spark" / "src" / "test"
-      / s"scala${if (flavor == EMR613) "-emr613" else "-legacy"}"
-  )
-  .dependsOn(consumers_spark % dependCompileOnCompileAndTestOnTest)
-  .settings(libraryDependencies ++= dependencies.pluginKafkaSparkOldDependencies)
-
 lazy val plugin_raw_spark = Project("wasp-plugin-raw-spark", file("plugin-raw-spark"))
   .settings(settings.commonSettings: _*)
   .settings(libraryDependencies ++= dependencies.sparkPluginBasicDependencies)
@@ -286,7 +275,6 @@ lazy val plugin =
         plugin_jdbc_spark,
         plugin_postgresql_spark,
         plugin_kafka_spark,
-        plugin_kafka_spark_old,
         plugin_raw_spark,
         plugin_solr_spark,
         plugin_cdc_spark,

plugin-kafka-spark-old/src/test/resources/log4j.xml

@@ -5,7 +5,6 @@ import sbt.Keys.{libraryDependencies, transitiveClassifiers}
 class CDP719Dependencies(versions: CDP719Versions) extends Dependencies {
 
   lazy val spark_sql_kafka     = "it.agilelab"     %% "wasp-spark-sql-kafka"     % "0.2.0-2.4.1-2.4.8-7.1.9.0-387-SNAPSHOT"
-  lazy val spark_sql_kafka_old = "it.agilelab"     %% "wasp-spark-sql-kafka-old" % "0.2.0-2.4.1-2.4.8-7.1.9.0-387-SNAPSHOT"
   lazy val delta               = "it.agilelab"     %% "wasp-delta-lake"          % "0.6.1-2.4.8.7.1.9.0-387"
   lazy val solrj               = "org.apache.solr" % "solr-solrj"                % versions.solr
   lazy val sparkSolr = versions.scala.take(4) match {
@@ -629,7 +628,6 @@ class CDP719Dependencies(versions: CDP719Versions) extends Dependencies {
     scalaTest
   )
   override lazy val pluginKafkaSparkDependencies: Seq[sbt.ModuleID]    = Seq(spark_sql_kafka) ++ testDependencies
-  override lazy val pluginKafkaSparkOldDependencies: Seq[sbt.ModuleID] = Seq(spark_sql_kafka_old) ++ testDependencies
   override lazy val pluginSolrSparkDependencies: Seq[sbt.ModuleID]     = Seq(sparkSolr, solrj) ++ testDependencies
   override lazy val pluginMongoSparkDependencies: Seq[sbt.ModuleID] = Seq(
     ("org.mongodb.spark" %% "mongo-spark-connector" % "2.4.3").exclude("org.mongodb", "mongo-java-driver"),

plugin-kafka-spark-old/src/test/resources/log4j2.xml

@@ -23,7 +23,6 @@ trait Dependencies {
   val pluginPlainHbaseWriterSparkDependencies: Seq[ModuleID]
   val pluginPostgreSQLSparkDependencies: Seq[ModuleID]
   val pluginKafkaSparkDependencies: Seq[ModuleID]
-  val pluginKafkaSparkOldDependencies: Seq[ModuleID]
   val pluginSolrSparkDependencies: Seq[ModuleID]
   val pluginMongoSparkDependencies: Seq[ModuleID]
   val pluginMailerSparkDependencies: Seq[ModuleID]

project/CDP719Dependencies.scala

@@ -198,10 +198,6 @@ class EMR613Dependencies(val versions: EMR613Versions)
     (Seq(sparkSqlKafka) ++ _pluginKafkaSparkDependencies)
       .map(_.exclude(exclusions.log4jExclude ++ exclusions.nettyExclude)) ++ logging ++ Seq(nettyAll)
 
-  override val pluginKafkaSparkOldDependencies: Seq[ModuleID] =
-    (_pluginKafkaSparkDependencies)
-      .map(_.exclude(exclusions.log4jExclude ++ exclusions.nettyExclude)) ++ logging ++ Seq(nettyAll)
-
   override val pluginSolrSparkDependencies: Seq[ModuleID] = spark ++ Seq(
     httpClient,
     httpCore,

project/Dependencies.scala

@@ -176,10 +176,6 @@ class Vanilla2Dependencies(val versions: Vanilla2Versions)
     (Seq(sparkSqlKafka) ++ _pluginKafkaSparkDependencies)
       .map(_.exclude(exclusions.log4jExclude ++ exclusions.nettyExclude)) ++ logging ++ Seq(nettyAll)
 
-  override val pluginKafkaSparkOldDependencies: Seq[ModuleID] =
-    (Seq(sparkSqlKafkaOld) ++ _pluginKafkaSparkDependencies)
-      .map(_.exclude(exclusions.log4jExclude ++ exclusions.nettyExclude)) ++ logging ++ Seq(nettyAll)
-
   override val pluginSolrSparkDependencies: Seq[ModuleID] = spark ++ Seq(
     httpClient,
     httpCore,
@@ -389,7 +385,6 @@ trait Vanilla2KafkaDependencies {
   lazy val kafkaStreaming   = "org.apache.spark" %% "spark-streaming-kafka-0-8" % versions.spark exclude (exclusions.sparkExclusions ++ exclusions.kafka08Exclude) // TODO remove jersey?
   lazy val kafkaTests       = kafka              % Test exclude (exclusions.jacksonExclude)
   lazy val sparkSqlKafka    = "it.agilelab"      %% "wasp-spark-sql-kafka" % versions.sparkSqlKafka
-  lazy val sparkSqlKafkaOld = "it.agilelab"      %% "wasp-spark-sql-kafka-old" % versions.sparkSqlKafka
 }
 
 trait Vanilla2MongoDependencies {