chore: use macro to reduce code

Author: akarsh1995

src/app_ui/async_task_channel.rs

@@ -22,47 +22,37 @@ pub enum TaskRequest {
     DbUpdateQuestion(Request<QuestionModel>),
 }
 
-impl TaskRequest {
-    pub async fn execute(
-        self,
-        client: &reqwest::Client,
-        conn: &DatabaseConnection,
-    ) -> TaskResponse {
-        match self {
-            TaskRequest::QuestionDetail(Request {
-                content: slug,
-                widget_name,
-                request_id,
-            }) => get_question_details(request_id, widget_name, slug, client).await,
-            TaskRequest::GetAllQuestionsMap(Request {
-                widget_name,
-                request_id,
-                ..
-            }) => get_all_questions(request_id, widget_name, conn).await,
-            TaskRequest::GetAllTopicTags(Request {
-                widget_name,
-                request_id,
-                ..
-            }) => get_all_topic_tags(request_id, widget_name, conn).await,
-            TaskRequest::GetQuestionEditorData(Request {
-                request_id,
-                content,
-                widget_name,
-            }) => get_editor_data(request_id, widget_name, content, client).await,
-            TaskRequest::CodeRunRequest(Request {
-                request_id,
-                content,
-                widget_name,
-            }) => run_or_submit_question(request_id, widget_name, content, client).await,
-            TaskRequest::DbUpdateQuestion(Request {
-                request_id,
-                content,
-                widget_name,
-            }) => update_status_to_accepted(request_id, widget_name, content, conn).await,
+macro_rules! impl_task_request {
+    ($(($var:ident, $f_name: ident)),*) => {
+        impl TaskRequest {
+            pub async fn execute(
+                self,
+                client: &reqwest::Client,
+                conn: &DatabaseConnection,
+            ) -> TaskResponse {
+                match self {
+                    $(
+                        TaskRequest::$var(Request {
+                            content,
+                            widget_name,
+                            request_id,
+                        }) => $f_name(request_id, widget_name, content, client, conn).await,
+                    )*
+                }
+            }
         }
-    }
+    };
 }
 
+impl_task_request!(
+    (QuestionDetail, get_question_details),
+    (GetAllQuestionsMap, get_all_questions),
+    (GetAllTopicTags, get_all_topic_tags),
+    (GetQuestionEditorData, get_editor_data),
+    (CodeRunRequest, run_or_submit_question),
+    (DbUpdateQuestion, update_status_to_accepted)
+);
+
 #[derive(Debug)]
 pub struct Response<T> {
     pub(crate) request_id: String,
@@ -81,21 +71,31 @@ pub enum TaskResponse {
     Error(Response<String>),
 }
 
-impl TaskResponse {
-    pub fn get_widget_name(&self) -> WidgetName {
-        match self {
-            TaskResponse::QuestionDetail(Response { widget_name, .. }) => widget_name,
-            TaskResponse::GetAllQuestionsMap(Response { widget_name, .. }) => widget_name,
-            TaskResponse::AllTopicTags(Response { widget_name, .. }) => widget_name,
-            TaskResponse::Error(Response { widget_name, .. }) => widget_name,
-            TaskResponse::QuestionEditorData(Response { widget_name, .. }) => widget_name,
-            TaskResponse::RunResponseData(Response { widget_name, .. }) => widget_name,
-            TaskResponse::DbUpdateStatus(Response { widget_name, .. }) => widget_name,
+macro_rules! impl_task_response {
+    ($($variant:ident),*) => {
+        impl TaskResponse {
+            pub fn get_widget_name(&self) -> WidgetName {
+                match self {
+                    $(
+                        TaskResponse::$variant(Response { widget_name, .. }) => widget_name,
+                    )*
+                }
+                .clone()
+            }
         }
-        .clone()
-    }
+    };
 }
 
+impl_task_response!(
+    QuestionDetail,
+    GetAllQuestionsMap,
+    AllTopicTags,
+    QuestionEditorData,
+    RunResponseData,
+    DbUpdateStatus,
+    Error
+);
+
 pub type ChannelRequestSender = tokio::sync::mpsc::UnboundedSender<TaskRequest>;
 pub type ChannelRequestReceiver = tokio::sync::mpsc::UnboundedReceiver<TaskRequest>;
 

src/app_ui/helpers/tasks.rs

@@ -13,6 +13,7 @@ pub async fn get_question_details(
     widget_name: WidgetName,
     slug: String,
     client: &reqwest::Client,
+    _conn: &DatabaseConnection,
 ) -> TaskResponse {
     match QuestionGQLQuery::new(slug).post(client).await {
         Ok(resp) => {
@@ -36,6 +37,7 @@ pub async fn get_editor_data(
     widget_name: WidgetName,
     slug: String,
     client: &reqwest::Client,
+    _conn: &DatabaseConnection,
 ) -> TaskResponse {
     match QuestionEditorDataQuery::new(slug).post(client).await {
         Ok(data) => TaskResponse::QuestionEditorData(Response {
@@ -54,6 +56,8 @@ pub async fn get_editor_data(
 pub async fn get_all_questions(
     request_id: String,
     widget_name: WidgetName,
+    _content: (),
+    _client: &reqwest::Client,
     conn: &DatabaseConnection,
 ) -> TaskResponse {
     match TopicTagEntity::get_all_topic_questions_map(conn).await {
@@ -73,6 +77,8 @@ pub async fn get_all_questions(
 pub async fn get_all_topic_tags(
     request_id: String,
     widget_name: WidgetName,
+    _content: (),
+    _client: &reqwest::Client,
     conn: &DatabaseConnection,
 ) -> TaskResponse {
     match TopicTagEntity::get_all_topics(conn).await {
@@ -94,6 +100,7 @@ pub async fn run_or_submit_question(
     widget_name: WidgetName,
     mut run_or_submit_code: graphql::RunOrSubmitCode,
     client: &reqwest::Client,
+    _conn: &DatabaseConnection,
 ) -> TaskResponse {
     if let RunOrSubmitCode::Run(RunCode {
         test_cases_stdin,
@@ -136,6 +143,7 @@ pub async fn update_status_to_accepted(
     request_id: String,
     widget_name: WidgetName,
     question: QuestionModel,
+    _client: &reqwest::Client,
     db: &DatabaseConnection,
 ) -> TaskResponse {
     let mut am = question.into_active_model();