feat(babel): upgrade and set newer browser targets (#6422)

* feat(babel): upgrade and set newer browser targets

* fix @babel/traverse security issue

* remove unused babel plugin

* dedupe lockfile

* add babel to vue-instantsearch

* exclude helper docs from eslint rule

---------

Co-authored-by: Haroen Viaene <[email protected]>

Author: aymeric-giraudet

.eslintrc.js

@@ -215,21 +215,11 @@ const config = {
       rules: {
         'no-restricted-syntax': [
           'error',
-          {
-            selector: '[async=true]',
-            message:
-              'The polyfill for async/await is very large, which is why we use promise chains',
-          },
           {
             selector: 'ForInStatement',
             message:
               'for..in loops iterate over the entire prototype chain, which is virtually never what you want. Use Object.{keys,values,entries}, and iterate over the resulting array.',
           },
-          {
-            selector: 'ForOfStatement',
-            message:
-              'iterators/generators require regenerator-runtime, which is too heavyweight for this guide to allow them. Separately, loops should be avoided in favor of array iterations.',
-          },
           {
             selector: 'LabeledStatement',
             message:
@@ -243,6 +233,23 @@ const config = {
         ],
       },
     },
+    {
+      files: 'packages/**/*',
+      excludedFiles: [
+        '*.test.*',
+        '**/__tests__/**',
+        '**/stories/**',
+        'packages/algoliasearch-helper/documentation-src/**',
+      ],
+      plugins: ['compat'],
+      extends: ['plugin:compat/recommended'],
+      env: {
+        browser: true,
+      },
+      settings: {
+        lintAllEsApis: true,
+      },
+    },
     // Disable stricter rules introduced for the next versions of the libraries.
     {
       files: [

babel.config.js

@@ -18,7 +18,7 @@ module.exports = (api) => {
   if (isTest) {
     targets.node = true;
   } else {
-    targets.browsers = ['last 2 versions', 'ie >= 9'];
+    targets.browsers = require('./package.json').browserslist;
   }
 
   const testPlugins = [
@@ -61,46 +61,6 @@ module.exports = (api) => {
         ],
       },
     ],
-    // this plugin is used to test if we need polyfills, not to actually insert them
-    // only UMD, since cjs & esm have false positives due to imports
-    isUMD && [
-      'polyfill-es-shims',
-      {
-        method: 'usage-global',
-        targets: {
-          ie: 11,
-        },
-        shouldInjectPolyfill(name, defaultShouldInject) {
-          const exclude = [
-            // false positives (we access these from objects only)
-            'Array.prototype.item',
-            'String.prototype.item',
-            'Array.prototype.values',
-            'Function.prototype.name',
-
-            // we require polyfills for this already
-            'Array.prototype.includes',
-
-            // false positive (babel doesn't know types)
-            // this is actually only called on arrays
-            'String.prototype.includes',
-
-            // false positive (spread)
-            'Object.getOwnPropertyDescriptors',
-
-            // @TODO: see when we remove IE11 support
-            'Object.fromEntries',
-            'Object.entries',
-          ];
-          if (defaultShouldInject && !exclude.includes(name)) {
-            throw new Error(
-              `Usage of a builtin which isn't allowed to be polyfilled: ${name}`
-            );
-          }
-          return false;
-        },
-      },
-    ],
   ]);
 
   return {

examples/js/algolia-experiences/package.json

@@ -13,7 +13,7 @@
     "instantsearch.css": "8.5.1"
   },
   "devDependencies": {
-    "@babel/core": "7.15.5",
+    "@babel/core": "7.25.9",
     "@parcel/core": "2.10.0",
     "@parcel/packager-raw-url": "2.10.0",
     "@parcel/transformer-webmanifest": "2.10.0",

examples/js/calendar-widget/package.json

@@ -13,7 +13,7 @@
     "instantsearch.js": "4.77.0"
   },
   "devDependencies": {
-    "@babel/core": "7.15.5",
+    "@babel/core": "7.25.9",
     "@parcel/packager-raw-url": "2.10.0",
     "@parcel/transformer-webmanifest": "2.10.0",
     "parcel": "2.10.0"

examples/js/e-commerce-umd/package.json

@@ -14,7 +14,7 @@
     "instantsearch.js": "4.77.0"
   },
   "devDependencies": {
-    "@babel/core": "7.15.5",
+    "@babel/core": "7.25.9",
     "@parcel/core": "2.10.0",
     "@parcel/packager-raw-url": "2.10.0",
     "@parcel/transformer-webmanifest": "2.10.0",

examples/js/e-commerce/package.json

@@ -14,7 +14,7 @@
     "instantsearch.js": "4.77.0"
   },
   "devDependencies": {
-    "@babel/core": "7.15.5",
+    "@babel/core": "7.25.9",
     "@parcel/core": "2.10.0",
     "@parcel/packager-raw-url": "2.10.0",
     "@parcel/transformer-webmanifest": "2.10.0",

examples/js/getting-started/package.json

@@ -14,7 +14,7 @@
     "instantsearch.js": "4.77.0"
   },
   "devDependencies": {
-    "@babel/core": "7.15.5",
+    "@babel/core": "7.25.9",
     "@parcel/core": "2.10.0",
     "@parcel/packager-raw-url": "2.10.0",
     "@parcel/transformer-webmanifest": "2.10.0",

examples/js/media/package.json

@@ -15,7 +15,7 @@
     "instantsearch.js": "4.77.0"
   },
   "devDependencies": {
-    "@babel/core": "7.15.5",
+    "@babel/core": "7.25.9",
     "@parcel/core": "2.10.0",
     "@parcel/packager-raw-url": "2.10.0",
     "@parcel/transformer-webmanifest": "2.10.0",

examples/js/tourism/package.json

@@ -13,7 +13,7 @@
     "instantsearch.js": "4.77.0"
   },
   "devDependencies": {
-    "@babel/core": "7.15.5",
+    "@babel/core": "7.25.9",
     "@parcel/core": "2.10.0",
     "@parcel/packager-raw-url": "2.10.0",
     "@parcel/transformer-webmanifest": "2.10.0",

examples/react/react-native/package.json

@@ -21,7 +21,7 @@
     "react-native-web": "0.17.1"
   },
   "devDependencies": {
-    "@babel/core": "7.15.5",
+    "@babel/core": "7.25.9",
     "@types/react": "~17.0.21",
     "@types/react-native": "~0.64.12",
     "expo-cli": "5.1.1",