Skip to content

Commit 912799d

Browse files
slonkaMarcin SkalskiFerdudas97
authored
Delta xds (#255)
* Use jcp version with delta xds * Switch JCP version to hash byte array * Convert snapshots to strings to do the comparision, otherwise some type checking fails * tmp * Since using delta mode, cache single messages not whole collections * Make ktlint pass * Do not call resources on every loop invocation. Enable cache metrics * Hold resuling resources in the global snapshot instead of calling it * Revert application-local port * Revert cache metrics * Add delta test for metered connections and requests * Add delta requests in metrics docs * Reused ADS config instead of making another one * Replace star imports with single line imports * Fix imports * Use DeltaAds as random * Add DeltaAds to random config list * Fix ktlint * Only send RDS when LDS or RDS changed * Use delta xds everywhere * Revert "Only send RDS when LDS or RDS changed" This reverts commit 600d7f3. * Revert to random Ads Xds Delta * Revert "Revert "Only send RDS when LDS or RDS changed"" This reverts commit b9637cb. * Revert "Use delta xds everywhere" This reverts commit 85da782. * Make tests for DeltaAds, Ads with * in dependencies and random * Kick ci * Upgrade Envoy version to 1.8.2 * fixed ktlint * removed deprecated api v2 usage (#264) removed deprecated api v2 usage * jcenter removed * update detekt version and fix warnings * ktlint fix * changes after merge * changes after merge * resolve merge conflicts * refactor delta xds * delta xds property * fix ktLint * add delta to ads * change config for DeltaAdsEnvoyControlSmokeTest * change java-control-plane snapshot version * changelog added * update java-control-plane * revert singe serialization * resolve conflicts * configure netty event loops Co-authored-by: Marcin Skalski <[email protected]> Co-authored-by: radoslaw.chrzanowski <[email protected]>
1 parent 558fc7f commit 912799d

File tree

36 files changed

+823
-301
lines changed

36 files changed

+823
-301
lines changed

CHANGELOG.md

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,3 @@
1-
2-
31
# Changelog
42

53
Lists all changes with user impact.
@@ -22,6 +20,11 @@ The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/).
2220

2321
## [0.19.19]
2422

23+
### Changed
24+
- Added support for Delta XDS
25+
26+
## [0.19.19]
27+
2528
### Changed
2629
- Add default access log filter configuration
2730

@@ -44,7 +47,7 @@ The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/).
4447

4548
### Changed
4649
- Added flags for lua filters
47-
50+
-
4851
## [0.19.14]
4952

5053
### Changed

build.gradle

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -47,9 +47,9 @@ allprojects {
4747

4848
project.ext.versions = [
4949
kotlin : '1.6.10',
50-
java_controlplane : '0.1.32',
50+
java_controlplane : '0.1.35',
5151
spring_boot : '2.3.4.RELEASE',
52-
grpc : '1.21.0',
52+
grpc : '1.48.1',
5353
jaxb : '2.3.1',
5454
javaxactivation : '1.2.0',
5555
micrometer : '1.5.5',

docs/changelog_symlink.md

Lines changed: 0 additions & 1 deletion
This file was deleted.

docs/changelog_symlink.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
../CHANGELOG.md

docs/configuration.md

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,8 +7,8 @@ Property
77
------------------------------------------------------------------------------------------- | ----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- | ---------
88
**envoy-control.server.executor-group.type** | Group executor type. DIRECT or PARALLEL | DIRECT
99
**envoy-control.server.executor-group.parallel-pool-size** | Pool size used for executor group in PARALLEL mode | 4
10-
**envoy-control.server.nio-event-loop-thread-count** | The number of threads that will be used by netty's nio event loop | 1
11-
**envoy-control.server.nio-event-loop-pool-size** | Pool size of NIO Event Loop | 0 (Number of CPUs * 2)
10+
**envoy-control.server.nio-event-loop-thread-count** | The number of threads that will be used by netty's nio worker event loop | 1
11+
**envoy-control.server.nio-boss-event-loop-thread-count** | The number of threads that will be used by netty's nio boss event loop | 1
1212
**envoy-control.server.netty.keep-alive-time** | Sets a custom keepalive time for Netty server | 15s
1313
**envoy-control.server.netty.permit-keep-alive-time** | Specify the most aggressive keep-alive time clients are permitted to configure (in seconds) | 10s
1414
**envoy-control.server.netty.permit-keep-alive-without-calls** | Sets whether to allow clients to send keep-alive HTTP/2 PINGs even if there are no outstanding RPCs on the connection | true
@@ -89,6 +89,7 @@ Property
8989
**envoy-control.envoy.snapshot.max-host-ttl** | The TTL for hosts that are unused. Hosts that have not been used in the configured time interval will be purged | 300s
9090
**envoy-control.envoy.snapshot.rate-limit.domain** | Domain name for ratelimit service. | rl
9191
**envoy-control.envoy.snapshot.rate-limit.service-name** | ratelimit GRPC service name | ratelimit-grpc
92+
**envoy-control.envoy.snapshot.delta-xds-enabled** | Enable detla xds | false
9293
**envoy-control.envoy.snapshot.should-audit-global-snapshot** | Enable global snapshot audits | false
9394

9495

docs/deployment/observability.md

Lines changed: 14 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -51,14 +51,20 @@ Metric | Description
5151

5252
#### xDS requests
5353

54-
Metric | Description
55-
--------------------------| --------------------------------------------------------
56-
**grpc.requests.cds** | Counter of received gRPC CDS requests
57-
**grpc.requests.eds** | Counter of received gRPC EDS requests
58-
**grpc.requests.lds** | Counter of received gRPC LDS requests
59-
**grpc.requests.rds** | Counter of received gRPC RDS requests
60-
**grpc.requests.sds** | Counter of received gRPC SDS requests
61-
**grpc.requests.unknown** | Counter of received gRPC requests for unknown resource
54+
Metric | Description
55+
------------------------------- | --------------------------------------------------------
56+
**grpc.requests.cds** | Counter of received gRPC CDS requests
57+
**grpc.requests.eds** | Counter of received gRPC EDS requests
58+
**grpc.requests.lds** | Counter of received gRPC LDS requests
59+
**grpc.requests.rds** | Counter of received gRPC RDS requests
60+
**grpc.requests.sds** | Counter of received gRPC SDS requests
61+
**grpc.requests.unknown** | Counter of received gRPC requests for unknown resource
62+
**grpc.requests.cds.delta** | Counter of received gRPC delta CDS requests
63+
**grpc.requests.eds.delta** | Counter of received gRPC delta EDS requests
64+
**grpc.requests.lds.delta** | Counter of received gRPC delta LDS requests
65+
**grpc.requests.rds.delta** | Counter of received gRPC delta RDS requests
66+
**grpc.requests.sds.delta** | Counter of received gRPC delta SDS requests
67+
**grpc.requests.unknown.delta** | Counter of received gRPC delta requests for unknown resource
6268

6369
#### Snapshot
6470

envoy-control-core/src/main/java/pl/allegro/tech/servicemesh/envoycontrol/GroupCacheStatusInfo.java

Lines changed: 0 additions & 44 deletions
This file was deleted.

0 commit comments

Comments
 (0)